Re: [jira] Updated: (MAPREDUCE-1320) StringBuffer -> StringBuilder occurence

[Kay Kay <ka...@gmail.com>]

This is an optimization, but nevertheless a low-hanging fruit , mostly 
at toString() methods regarding the use of the right 'Appendable' 
string.  The build failures have nothing to do with the patch.  Can 
somebody review this. Thanks.



Kay Kay (JIRA) wrote:
>      [ https://issues.apache.org/jira/browse/MAPREDUCE-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Kay Kay updated MAPREDUCE-1320:
> -------------------------------
>
>     Attachment:     (was: MAPREDUCE-1320.patch)
>
>   
>> StringBuffer -> StringBuilder occurence 
>> ----------------------------------------
>>
>>                 Key: MAPREDUCE-1320
>>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1320
>>             Project: Hadoop Map/Reduce
>>          Issue Type: Improvement
>>    Affects Versions: 0.20.1
>>            Reporter: Kay Kay
>>             Fix For: 0.20.2
>>
>>         Attachments: MAPREDUCE-1320.patch
>>
>>
>> A good number of toString() implementations use StringBuffer when the reference clearly does not go out of scope of the method and no concurrency is needed. Patch contains replacing those occurences from StringBuffer to StringBuilder. 
>> Created against map/reduce project trunk . 
>>     
>
>