You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/04/13 09:08:02 UTC

[GitHub] [kylin] zhengshengjun opened a new pull request #1631: KYLIN-4941 support encoding raw data to base cuboid column-by-column

zhengshengjun opened a new pull request #1631:
URL: https://github.com/apache/kylin/pull/1631


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [x] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] codecov-io commented on pull request #1631: KYLIN-4941 support encoding raw data to base cuboid column-by-column

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1631:
URL: https://github.com/apache/kylin/pull/1631#issuecomment-818775584


   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1631?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1631](https://codecov.io/gh/apache/kylin/pull/1631?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (528ad97) into [master](https://codecov.io/gh/apache/kylin/commit/02500818d85955b1125340eaa19ab88a634a5181?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0250081) will **decrease** coverage by `0.11%`.
   > The diff coverage is `5.21%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1631/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/kylin/pull/1631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1631      +/-   ##
   ============================================
   - Coverage     25.42%   25.31%   -0.12%     
   + Complexity     6765     6762       -3     
   ============================================
     Files          1508     1509       +1     
     Lines         93918    94358     +440     
     Branches      13158    13230      +72     
   ============================================
   + Hits          23877    23883       +6     
   - Misses        67662    68092     +430     
   - Partials       2379     2383       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.40% <0.00%> (-0.07%)` | `51.00 <0.00> (ø)` | |
   | [...in/java/org/apache/kylin/cube/CubeDescManager.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVEZXNjTWFuYWdlci5qYXZh) | `32.41% <0.00%> (-1.16%)` | `12.00 <0.00> (ø)` | |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `35.83% <0.00%> (-0.81%)` | `44.00 <0.00> (ø)` | |
   | [...c/main/java/org/apache/kylin/cube/CubeSegment.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVTZWdtZW50LmphdmE=) | `41.21% <0.00%> (-1.07%)` | `65.00 <0.00> (ø)` | |
   | [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `57.02% <0.00%> (-1.34%)` | `182.00 <0.00> (ø)` | |
   | [...n/java/org/apache/kylin/cube/model/RowKeyDesc.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL1Jvd0tleURlc2MuamF2YQ==) | `71.42% <0.00%> (-11.91%)` | `17.00 <0.00> (ø)` | |
   | [...a/org/apache/kylin/job/common/ShellExecutable.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9jb21tb24vU2hlbGxFeGVjdXRhYmxlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/apache/kylin/job/execution/BrokenExecutable.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQnJva2VuRXhlY3V0YWJsZS5qYXZh) | `60.00% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ylin/job/impl/threadpool/DistributedScheduler.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGlzdHJpYnV0ZWRTY2hlZHVsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...g/apache/kylin/job/impl/threadpool/IJobRunner.java](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvSUpvYlJ1bm5lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [72 more](https://codecov.io/gh/apache/kylin/pull/1631/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1631?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1631?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [69368b0...528ad97](https://codecov.io/gh/apache/kylin/pull/1631?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhengshengjun commented on a change in pull request #1631: KYLIN-4941 support encoding raw data to base cuboid column-by-column

Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on a change in pull request #1631:
URL: https://github.com/apache/kylin/pull/1631#discussion_r642321082



##########
File path: engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingByLayer.java
##########
@@ -330,15 +409,12 @@ public EncodeBaseCuboid(String cubeName, String segmentId, String metaurl, Seria
                             long baseCuboidId = Cuboid.getBaseCuboidId(cubeDesc);
                             Cuboid baseCuboid = Cuboid.findForMandatory(cubeDesc, baseCuboidId);
                             String splitKey = String.valueOf(TaskContext.getPartitionId());
-                            try {

Review comment:
       The original implementation will catch exception and print StackTrace in stand output, the spark job will continue to run. Maybe it's not an expected behavior, should we remove try catch and fail fast ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on a change in pull request #1631: KYLIN-4941 support encoding raw data to base cuboid column-by-column

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1631:
URL: https://github.com/apache/kylin/pull/1631#discussion_r633995459



##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2709,7 +2709,11 @@ public int getDistCPMaxMapNum(){
         return Integer.valueOf(getOptional("kylin.storage.distcp-max-map-num", "50"));
     }
 
-    public String getKylinDictCacheStrength(){
+    public String getKylinDictCacheStrength() {
         return getOptional("kylin.dict.cache.strength", "soft");
-    };
+    }
+
+    public boolean encodeBaseCuboidColumnByColumn() {

Review comment:
       Could you please kindly add some explanation of this `property`? Maybe some suggestion about in which case should we enable this feature. Or explain it main principle.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhengshengjun commented on a change in pull request #1631: KYLIN-4941 support encoding raw data to base cuboid column-by-column

Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on a change in pull request #1631:
URL: https://github.com/apache/kylin/pull/1631#discussion_r634136575



##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2709,7 +2709,11 @@ public int getDistCPMaxMapNum(){
         return Integer.valueOf(getOptional("kylin.storage.distcp-max-map-num", "50"));
     }
 
-    public String getKylinDictCacheStrength(){
+    public String getKylinDictCacheStrength() {
         return getOptional("kylin.dict.cache.strength", "soft");
-    };
+    }
+
+    public boolean encodeBaseCuboidColumnByColumn() {

Review comment:
       Sure, thanks you for your advice ~




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhangayqian commented on a change in pull request #1631: KYLIN-4941 support encoding raw data to base cuboid column-by-column

Posted by GitBox <gi...@apache.org>.
zhangayqian commented on a change in pull request #1631:
URL: https://github.com/apache/kylin/pull/1631#discussion_r633984742



##########
File path: engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingByLayer.java
##########
@@ -330,15 +409,12 @@ public EncodeBaseCuboid(String cubeName, String segmentId, String metaurl, Seria
                             long baseCuboidId = Cuboid.getBaseCuboidId(cubeDesc);
                             Cuboid baseCuboid = Cuboid.findForMandatory(cubeDesc, baseCuboidId);
                             String splitKey = String.valueOf(TaskContext.getPartitionId());
-                            try {

Review comment:
       Why remove this try catch?

##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -2709,7 +2709,11 @@ public int getDistCPMaxMapNum(){
         return Integer.valueOf(getOptional("kylin.storage.distcp-max-map-num", "50"));
     }
 
-    public String getKylinDictCacheStrength(){
+    public String getKylinDictCacheStrength() {
         return getOptional("kylin.dict.cache.strength", "soft");
-    };
+    }
+
+    public boolean encodeBaseCuboidColumnByColumn() {
+        return Boolean.valueOf(getOptional("kylin.job.encode.base.cuboid.column-by-column", "false"));

Review comment:
       Is this configuration item more suitable for cube level configuration?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org