You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/10/01 18:07:40 UTC
[PR] Fix line wrapping in MCP tool exception test [shardingsphere]
terrymanu opened a new pull request, #40030:
URL: https://github.com/apache/shardingsphere/pull/40030
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix line wrapping in MCP tool exception test [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40030:
URL: https://github.com/apache/shardingsphere/pull/40030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix line wrapping in MCP tool exception test [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40030:
URL: https://github.com/apache/shardingsphere/pull/40030#issuecomment-5937504773
### Result
**Review Result: Mergeable**
The fix is now in your **dev working directory**: one file changed, 2 insertions and 2 deletions.
### Evidence
- Extracted `expectedException` and joined the Mockito statement onto one 192-character line.
- Checkstyle and Spotless passed, exit **0**.
- All **8 tests passed**, exit **0**, after rebuilding source dependencies with `-am`.
### Coverage
Standalone local candidate, baseline `6535878aee779c1350bc54da401f7f9a69be7333`.
Reviewed file: `mcp/bootstrap/src/test/java/org/apache/shardingsphere/mcp/bootstrap/transport/capability/tool/MCPToolSpecificationFactoryTest.java:137`.
Existing exception behavior and assertions are preserved. Scope audit, all three review lenses, and convergence completed; no remaining findings or evidence gaps. This conclusion covers the local dev change. CI was not reviewed.
Jev: skill unused; 0 MCP calls because the work required multi-step verification. No routing changes; efficiency cannot be measured accurately; problems: none found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org