You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "yumosx (via GitHub)" <gi...@apache.org> on 2025/11/17 05:45:29 UTC
[PR] handle typed nil pointers in encode [dubbo-go-hessian2]
yumosx opened a new pull request, #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes https://github.com/apache/dubbo-go/issues/2517
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
handle typed nil pointers such as (*int32)(nil) by encoding them as hessian null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "wongoo (via GitHub)" <gi...@apache.org>.
wongoo commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-3544692269
@yumosx unit test TestMultipleLevelRecursiveDep2 failed, u can update the test and re-run the CI to check the reason:
```go
decoded := fmt.Sprintf("%v", obj)
origin := fmt.Sprintf("%v", data)
if decoded != origin {
t.Errorf("deserialize mismatched, origin: %s, decoded: %s", origin, decoded)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "yumosx (via GitHub)" <gi...@apache.org>.
yumosx commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-3544836675
Hi @wongoo,thanks for your review, this test seems correct. The CI failure was caused by another [reason]( https://github.com/apache/dubbo-go-hessian2/pull/375.) I will create a PR to fix it later.
<img width="639" height="282" alt="image" src="https://github.com/user-attachments/assets/e4a3414f-8753-4d99-8eda-2f1c6624c6b1" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "tiltwind (via GitHub)" <gi...@apache.org>.
tiltwind commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4333731920
@mochengqian YES, pls ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "yumosx (via GitHub)" <gi...@apache.org>.
yumosx commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4234487351
这个pr的 代码好像没有问题，有问题的是另外一个文件有bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "mochengqian (via GitHub)" <gi...@apache.org>.
mochengqian commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4234356911
> @mochenqian 你也遇到过同样的问题吗？你试过v1.13.0版本吗？
I haven't seen this problem in my own usage, and I haven't tried reproducing it with v1.13.0 yet.
If no one follows up, I can follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "mochengqian (via GitHub)" <gi...@apache.org>.
mochengqian commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4331718492
> @yumosx the master branch can pass the unit test in this pr ,see #391 . Do these unit tests simulate the issues?
It has been verified that the specific (*int32)(nil) case mentioned in apache/dubbo-go#2517 **has been handled in the current main branch**. encTypeInt32 encodes nil *int32 as Hessian null, and TestNullInt32Ptr verifies that the output is N. PR #391 also confirms that the tests in this PR pass on the main branch. **Therefore, PR #384 is no longer needed for the reported hessian2 behavior.** The remaining work on apache/dubbo-go#2517 should focus on the propagation of the dubbo-go protocol layer error and end-to-end reproduction. @wongoo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "tiltwind (via GitHub)" <gi...@apache.org>.
tiltwind commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4234524657
@yumosx 不确定这个pr是否还需要， 这个pr的UT在当前最新代码中也是可以通过的，最新代码可能已经处理了， 你能验证一下吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "wongoo (via GitHub)" <gi...@apache.org>.
wongoo commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4152871726
@yumosx the master branch can pass the unit test in this pr ,see https://github.com/apache/dubbo-go-hessian2/pull/391 . Do these unit tests simulate the issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "yumosx (via GitHub)" <gi...@apache.org>.
yumosx commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-3631132708
@wongoo @AlexStocks The CI failure issue has been fully resolved by https://github.com/apache/dubbo-go-hessian2/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "tiltwind (via GitHub)" <gi...@apache.org>.
tiltwind commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4234205615
@mochenqian Have you also encountered the same problem? Have you tried the version v1.13.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "wongoo (via GitHub)" <gi...@apache.org>.
wongoo closed pull request #384: handle typed nil pointers in encode
URL: https://github.com/apache/dubbo-go-hessian2/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "MoChengqian (via GitHub)" <gi...@apache.org>.
MoChengqian commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4149417990
@MoChengqian
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "mochengqian (via GitHub)" <gi...@apache.org>.
mochengqian commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4272191099
> @yumosx 不确定这个pr是否还需要， 这个pr的UT在当前最新代码中也是可以通过的，最新代码可能已经处理了， 你能验证一下吗？
@ yumosx 需要帮忙吗?如果你没时间的话我来解决这个问题吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "mochengqian (via GitHub)" <gi...@apache.org>.
mochengqian commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4332126528
PR376 can also be turned off. Do I need to add a boundary test PR? @tiltwind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] handle typed nil pointers in encode [dubbo-go-hessian2]
Posted by "mochengqian (via GitHub)" <gi...@apache.org>.
mochengqian commented on PR #384:
URL: https://github.com/apache/dubbo-go-hessian2/pull/384#issuecomment-4231689414
Is anyone following up on this issue?@tiltwind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org