You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2017/05/03 11:50:19 UTC
[GitHub] brooklyn-server pull request #665: Delete catalog.xml support
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/665
Delete catalog.xml support
Use of `~/.brooklyn/catalog.xml` was deprecated in 0.7.0. This PR finally deletes the code for it.
Note that it deletes the rest api endpoint `/v1/catalog/reset` (which relied on there being a `catalog.xml`).
It also changes the way `fragment` is handled in things like `/v1/catalog/applications?fragment=...`. Previously it was use the `toXml`, and then do a case-insensitive search for the fragment. To try to keep the functionality as close as possible (with code as simple as possible), I've reused the persisted state serialization mechanism to produce the memento, and then do the case-insensitive search for the fragment in that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server delete-catalog.xml-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/665.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #665
----
commit cb20cce9afe9af4f0477b8c087951d057f2564a0
Author: Aled Sage <al...@gmail.com>
Date: 2017-03-20T13:15:22Z
Delete catalog.xml support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #665: Delete catalog.xml support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/665
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #665: Delete catalog.xml support
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/665
The error in jenkins looks like some system problem:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project brooklyn-core: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
```
Could you re-push to run the tests again please @aledsage?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #665: Delete catalog.xml support
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/665
Again the error in the jenkins appears to be unrelated to this, tests pass locally and Infra seem to have fixed the problem now. This PR looks good to me so I'm going to merge it now, thanks @aledsage!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---