You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2008/01/03 04:29:05 UTC
[VOTE] initial release of httpd-mod_ftp-0.9.1
mod_ftp fans;
We seem to have identified and solved most post 0.9.0 candidate issues,
so it's time for another try.
Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
their md5/asc sigs) from:
http://httpd.apache.org/dev/dist/mod_ftp/
review, take it for a spin, and cast your choice
[ ] -1 for any release of 0.9.1
[ ] +1 to release as 0.9.1-alpha
[ ] +1 to release as 0.9.1-beta
[ ] +1 to release as 0.9.1-beta, and ready to tag GA (1.0.0)
See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.1/STATUS-FTP
identifying several issues (I don't plan to vote for better than -beta
just yet). Supporting -beta means +1 to -alpha instead if that's the
majority opinion.
For getting started,
http://httpd.apache.org/mod_ftp/
which has links to all the various documentation. I haven't finished
the implementation of Makefile.win-ftp just yet, and didn't want to
hold up the release any more for just that, but docs on compiling for
win32 are also in README-FTP.
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
>> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
>> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
>> their md5/asc sigs), take it for a spin, and cast your choice
> There is one binding +1, no other votes. I count Guenter's +1 vote
> for removing STATUS-FTP, but not for a release.
-1 for Linux
-1 for NetWare
I've just found a serious issue where empty dirs are not listened - thus you cant change to them.
Happens on both Linux and NetWare, and I'm 100% sure that this worked before with an old version from last spring (2007-03-28) because at this time I did upload files to an empty 'incoming' folder.
I didnt find the time yet to dig into fixing the issue;
but I think we should first fix this and then together with the other changes in trunk tag 0.9.2.
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Niklas Edmundsson wrote:
>
> I haven't looked closer at the code, but it seems to me that
> something is broken. Should it even try to insert an ftp filter for
> non-ftp connections?
It should not, I think. Time for me to spend cycles in 2.2, since all
my testing was on 2.0, and try some dynamic content too.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Niklas Edmundsson <ni...@acc.umu.se>.
On Thu, 10 Jan 2008, Niklas Edmundsson wrote:
> On Wed, 9 Jan 2008, William A. Rowe, Jr. wrote:
>
>>> Uhm. It seems that the old bug of not delivering http with mod_ftp loaded
>>> is back... Or am I seeing a ghost? Same symptoms as before, 0-length
>>> replies...
>>
>> Ghost is possibly working in trunk without doing the make clean; make
>> I mentioned?
>
> I did ./configure.apxs; make clean; make ...
Did it again, just to be sure.
> Discovered now that I got a bunch of coredumps, will get back to you if I
> find something useful...
This is httpd 2.2.6, worker MPM, compiled with -g and with optimization,
on Ubuntu 7.10 32bit, mod_ftp trunk r610730.
Backtrace of cores looks like this:
(gdb) bt full
#0 0xffffe410 in __kernel_vsyscall ()
No symbol table info available.
#1 0xb7d71ca6 in kill () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
#2 0x0808179d in sig_coredump (sig=28177) at mpm_common.c:1235
No locals.
#3 <signal handler called>
No symbol table info available.
#4 ftp_insert_filter (r=0x81fc088) at mod_ftp.c:260
fc = (ftp_connection *) 0x0
#5 0x0807483c in ap_run_insert_filter (r=0x81fc088) at request.c:80
n = 2
#6 0x0807c200 in ap_invoke_handler (r=0x81fc088) at config.c:339
handler = <value optimized out>
result = <value optimized out>
old_handler = 0x0
ignore = <value optimized out>
#7 0x08086dd8 in ap_process_request (r=0x81fc088) at http_request.c:258
access_status = 136282760
#8 0x080840db in ap_process_http_connection (c=0x81f8228) at http_core.c:184
r = (request_rec *) 0x81fc088
csd = (apr_socket_t *) 0x0
#9 0x08080209 in ap_run_process_connection (c=0x81f8228) at connection.c:43
n = 1
rv = 18
#10 0x0808ba84 in worker_thread (thd=0x812c240, dummy=0x815bea8)
at worker.c:544
process_slot = 0
thread_slot = 0
csd = (apr_socket_t *) 0x81f8078
bucket_alloc = (apr_bucket_alloc_t *) 0x81fa048
last_ptrans = (apr_pool_t *) 0x0
ptrans = (apr_pool_t *) 0x81f8040
rv = <value optimized out>
is_idle = <value optimized out>
(gdb) frame 4
#4 ftp_insert_filter (r=0x81fc088) at mod_ftp.c:260
260 if (fc->datasock && (fc->filter_mask & FTP_NEED_DATA_OUT)) {
I guess that following a NULL pointer didn't work this time either ;)
I haven't looked closer at the code, but it seems to me that
something is broken. Should it even try to insert an ftp filter for
non-ftp connections?
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | nikke@acc.umu.se
---------------------------------------------------------------------------
ngel's lame. His hair grows straight up, and he's bloody stupid. - Buffybot
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Niklas Edmundsson <ni...@acc.umu.se>.
On Sun, 20 Jan 2008, William A. Rowe, Jr. wrote:
> Niklas - I found something telling, we were not sliding out of the
> way in insert_filters where we had not initialized our ftp connection
> struct. A quick test demonstrates the flaw is fixed.
>
> Try updating to trunk and take another quick whack at it - the ghost
> should be banished again.
So it seems, I can now speak http again while having mod_ftp loaded
and enabled :)
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | nikke@acc.umu.se
---------------------------------------------------------------------------
Why is "abbreviated" such a long word?
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Niklas Edmundsson wrote:
> On Wed, 9 Jan 2008, William A. Rowe, Jr. wrote:
>
>>> Uhm. It seems that the old bug of not delivering http with mod_ftp
>>> loaded is back... Or am I seeing a ghost? Same symptoms as before,
>>> 0-length replies...
>>
>> Ghost is possibly working in trunk without doing the make clean; make
>> I mentioned?
>
> I did ./configure.apxs; make clean; make ...
>
> Discovered now that I got a bunch of coredumps, will get back to you if
> I find something useful...
Niklas - I found something telling, we were not sliding out of the
way in insert_filters where we had not initialized our ftp connection
struct. A quick test demonstrates the flaw is fixed.
Try updating to trunk and take another quick whack at it - the ghost
should be banished again.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Niklas Edmundsson <ni...@acc.umu.se>.
On Wed, 9 Jan 2008, William A. Rowe, Jr. wrote:
>> Uhm. It seems that the old bug of not delivering http with mod_ftp loaded
>> is back... Or am I seeing a ghost? Same symptoms as before, 0-length
>> replies...
>
> Ghost is possibly working in trunk without doing the make clean; make
> I mentioned?
I did ./configure.apxs; make clean; make ...
Discovered now that I got a bunch of coredumps, will get back to you
if I find something useful...
/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | nikke@acc.umu.se
---------------------------------------------------------------------------
I AM HELGA OF BORG ! AND DON'T MAKE ME SCREAM !
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Niklas Edmundsson wrote:
>
>> The changes in trunk are rational but widely distributed, we now set up
>> a single initialization where once we had many, for an assortment of
>> state variables. Those sorts of changes are prone to fallout. If you
>> are playing with trunk and svn up, be sure to make clean; make straight
>> away. In any case, I don't see trunk as being releasable until folks
>> have bashed on it for a time, so if anyone's eager for 0.9.2 please test
>> trunk and chime in once you believe it's ready to tag.
>
> Uhm. It seems that the old bug of not delivering http with mod_ftp
> loaded is back... Or am I seeing a ghost? Same symptoms as before,
> 0-length replies...
Ghost is possibly working in trunk without doing the make clean; make
I mentioned?
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Niklas Edmundsson <ni...@acc.umu.se>.
On Tue, 8 Jan 2008, William A. Rowe, Jr. wrote:
> I've heard one + and one - for removing STATUS-FTP, and I think Jorge's
> point is well taken, at least for alphas and betas, so it seems it's
> worth leaving STATUS-FTP in our alpha and beta packages (and I think
> it's also a good point for httpd-2.3-alphas when we get to those.)
I'm for keeping STATUS-FTP in alphas and betas at least.
> The changes in trunk are rational but widely distributed, we now set up
> a single initialization where once we had many, for an assortment of
> state variables. Those sorts of changes are prone to fallout. If you
> are playing with trunk and svn up, be sure to make clean; make straight
> away. In any case, I don't see trunk as being releasable until folks
> have bashed on it for a time, so if anyone's eager for 0.9.2 please test
> trunk and chime in once you believe it's ready to tag.
Uhm. It seems that the old bug of not delivering http with mod_ftp
loaded is back... Or am I seeing a ghost? Same symptoms as before,
0-length replies...
/Nikke - cramming in some quick testing before going to bed...
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se | nikke@acc.umu.se
---------------------------------------------------------------------------
Get rid of temptation - Yield to it.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
>
>> I wouldn't mind a test for "httpd_conffile" = "", I think your patch
>> leaves a bit more of a chance for a subtle make install failure.
> huh? what you mean?
> In my case httpd_conffile wasnt empty but pointed to a non-existant file....
On my systems, that would be a bug, and I want install to croak.
If you didn't want it updated at all, make httpd_conffile="" would
accomplish that without misleading those who do. Right?
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
> You could simply override make httpd_conffile=/filepath which is the
> preferred way. Long ago this should have become an independent apxs
> variable.
ok.
> I wouldn't mind a test for "httpd_conffile" = "", I think your patch
> leaves a bit more of a chance for a subtle make install failure.
huh? what you mean?
In my case httpd_conffile wasnt empty but pointed to a non-existant file....
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
> on my box, a SuSE 10.1, the httpd-prefork.conf wasnt found, and thus the 'make install' broke....
> I did then insert a test for the file (not sure if this is the correct way, but at least I could then get past this issue, and finish the build):
You could simply override make httpd_conffile=/filepath which is the
preferred way. Long ago this should have become an independent apxs
variable.
I wouldn't mind a test for "httpd_conffile" = "", I think your patch
leaves a bit more of a chance for a subtle make install failure.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
>> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
>> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
>> their md5/asc sigs), take it for a spin, and cast your choice
> There is one binding +1, no other votes. I count Guenter's +1 vote
> for removing STATUS-FTP, but not for a release.
oh, forgot about another small build issue on Linux:
on my box, a SuSE 10.1, the httpd-prefork.conf wasnt found, and thus the 'make install' broke....
I did then insert a test for the file (not sure if this is the correct way, but at least I could then get past this issue, and finish the build):
--- Makefile.apxs.orig Tue Dec 18 22:38:06 2007
+++ Makefile.apxs Fri Jan 11 20:25:16 2008
@@ -61,12 +61,14 @@
fi; \
done ; \
done
- @awk -f $(ftp_srcdir)/build/addloadexample.awk \
- -v MODULE=ftp -v DSO=.so -v LIBPATH=$(rel_libexecdir) \
- -v EXAMPLECONF=$(rel_sysconfdir)/extra/ftpd.conf \
- $(httpd_conffile) > $(httpd_conffile).new && \
- ( mv $(httpd_conffile) $(httpd_conffile).bak && \
- mv $(httpd_conffile).new $(httpd_conffile) );
+ if test -e $(httpd_conffile); then \
+ @awk -f $(ftp_srcdir)/build/addloadexample.awk \
+ -v MODULE=ftp -v DSO=.so -v LIBPATH=$(rel_libexecdir) \
+ -v EXAMPLECONF=$(rel_sysconfdir)/extra/ftpd.conf \
+ $(httpd_conffile) > $(httpd_conffile).new && \
+ ( mv $(httpd_conffile) $(httpd_conffile).bak && \
+ mv $(httpd_conffile).new $(httpd_conffile) ); \
+ fi;
svnroot=http://svn.apache.org/repos/asf/httpd
manualdir=$(ftp_srcdir)/docs/manual
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote on 2008-01-02:
>
> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
> their md5/asc sigs), take it for a spin, and cast your choice
There is one binding +1, no other votes. I count Guenter's +1 vote
for removing STATUS-FTP, but not for a release. I promised to call
the vote Saturday (at three days) but since the winter break is an odd
time of year, and most active folks have been furiously reviewing the
various httpd release, I'll let the vote continue to sleep until
Saturday night, at which point it's released (alpha for 2.2) or DOA.
I've heard one + and one - for removing STATUS-FTP, and I think Jorge's
point is well taken, at least for alphas and betas, so it seems it's
worth leaving STATUS-FTP in our alpha and beta packages (and I think
it's also a good point for httpd-2.3-alphas when we get to those.)
The changes in trunk are rational but widely distributed, we now set up
a single initialization where once we had many, for an assortment of
state variables. Those sorts of changes are prone to fallout. If you
are playing with trunk and svn up, be sure to make clean; make straight
away. In any case, I don't see trunk as being releasable until folks
have bashed on it for a time, so if anyone's eager for 0.9.2 please test
trunk and chime in once you believe it's ready to tag.
Bill
[Results] [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> mod_ftp fans;
>
> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
> their md5/asc sigs) from:
Thanks to all who helped review and test; based on my tally, the release
of 0.9.1 fails, so it will be on to 0.9.2 once contributors agree it's
ready for the next release attempt.
All of the testing was much appreciated, and will help to ensure a solid
initial release!
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Jorge Schrauwen <jo...@gmail.com>.
I actualy like that the status files are packed, why aren't they
packed for the other packages?
But I'd say do what the others do.
On Jan 5, 2008 8:14 PM, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> Guenter Knauf wrote:
> >
> >> See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.1/STATUS-FTP
> >
> > first line of STATUS reads:
> > MOD_FTP 3.0 STATUS:
> >
> > a little bit strange the 3.0 while the module has now 0.9.1 version....
>
> Fixed. I would be happy to reroll without STATUS if people agree that
> it should be omitted; we don't actually package STATUS in other httpd
> related packages. WDYT?
>
--
~Jorge
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
>
>> See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.1/STATUS-FTP
>
> first line of STATUS reads:
> MOD_FTP 3.0 STATUS:
>
> a little bit strange the 3.0 while the module has now 0.9.1 version....
Fixed. I would be happy to reroll without STATUS if people agree that
it should be omitted; we don't actually package STATUS in other httpd
related packages. WDYT?
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi Bill,
> mod_ftp fans;
> See http://svn.apache.org/repos/asf/httpd/mod_ftp/tags/0.9.1/STATUS-FTP
first line of STATUS reads:
MOD_FTP 3.0 STATUS:
a little bit strange the 3.0 while the module has now 0.9.1 version....
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
> Need 2 +1's beyond my own to remove STATUS-FTP from the packages.
you have my +1 now already - since we dont ship STATUS with httpd packages either.
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
> their md5/asc sigs) from:
>
> [X] +1 to release as 0.9.1-alpha
If the announce states this is an alpha for httpd-2.2 I don't see any
significant issues. The crazy rate that I'm patching trunk/ isn't
related to any flaw, but it's leading to the goal of named virtual hosts
by USER name (e.g. will@apache.org -> Username: will, Host: apache.org).
If Guenter's suggestion about STATUS seeming odd, and we agree to drop the
STATUS-FTP file from the tarball, I'm happy to reroll before posting up
announce and 0.9.1 alpha. The only change I'd back is removing STATUS
since it's how we package httpd-x.x.tar.gz.
Need 2 +1's beyond my own to remove STATUS-FTP from the packages.
I'll call and count the vote this evening.
Bill
[Results] [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> mod_ftp fans;
>
> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
> their md5/asc sigs) from:
Thanks to all who helped review and test; based on my tally, the release
of 0.9.1 fails, so it will be on to 0.9.2 once contributors agree it's
ready for the next release attempt.
All of the testing was much appreciated, and will help to ensure a solid
initial release!
Bill
---------------------------------------------------------------------
To unsubscribe, e-mail: testers-unsubscribe@httpd.apache.org
For additional commands, e-mail: testers-help@httpd.apache.org
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote on 2008-01-02:
>
> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
> their md5/asc sigs), take it for a spin, and cast your choice
There is one binding +1, no other votes. I count Guenter's +1 vote
for removing STATUS-FTP, but not for a release. I promised to call
the vote Saturday (at three days) but since the winter break is an odd
time of year, and most active folks have been furiously reviewing the
various httpd release, I'll let the vote continue to sleep until
Saturday night, at which point it's released (alpha for 2.2) or DOA.
I've heard one + and one - for removing STATUS-FTP, and I think Jorge's
point is well taken, at least for alphas and betas, so it seems it's
worth leaving STATUS-FTP in our alpha and beta packages (and I think
it's also a good point for httpd-2.3-alphas when we get to those.)
The changes in trunk are rational but widely distributed, we now set up
a single initialization where once we had many, for an assortment of
state variables. Those sorts of changes are prone to fallout. If you
are playing with trunk and svn up, be sure to make clean; make straight
away. In any case, I don't see trunk as being releasable until folks
have bashed on it for a time, so if anyone's eager for 0.9.2 please test
trunk and chime in once you believe it's ready to tag.
Bill
---------------------------------------------------------------------
To unsubscribe, e-mail: testers-unsubscribe@httpd.apache.org
For additional commands, e-mail: testers-help@httpd.apache.org
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
>
> Furthermore if we would introduce an APR_VERSION_NUMBER like:
>
> #define APR_VERSION_NUMBER \
> (APR_MAJOR_VERSION * 1000000) + \
> (APR_MINOR_VERSION * 1000) + \
> APR_PATCH_VERSION
>
> we could do much easier version tests....
ABI and API versioning policy prohibits this change until 1.3
at earliest, but probably 2.0 for sanity. Patches always welcome.
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
>>
>> or should we do similar in ftp_commands.c depending on
>> MODULE_MAGIC_NUMBER ?
> The patch I committed for 0.9.2 tests the APR version, which the
> real test of this function's availability.
seen, that should be ok.
However I came over this already with other (external) modules, so asking me (and you) if we cant just backport the missing function? Why are we that strict against adding new functions? I believe new functions cant hurt anything if these are already for a while in later APR versions, and proofed to be stable, or?
Furthermore if we would introduce an APR_VERSION_NUMBER like:
#define APR_VERSION_NUMBER \
(APR_MAJOR_VERSION * 1000000) + \
(APR_MINOR_VERSION * 1000) + \
APR_PATCH_VERSION
we could do much easier version tests....
(forgive that I raise that here - but sometimes there _are_ some APR folks here on the list listening, smile....).
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
>
> or should we do similar in ftp_commands.c depending on MODULE_MAGIC_NUMBER ?
The patch I committed for 0.9.2 tests the APR version, which the
real test of this function's availability.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
> http://httpd.apache.org/dev/dist/mod_ftp/
> review, take it for a spin, and cast your choice
when compiling for 2.0.x I get an unresolved:
### mwldnlm Linker Error:
# Undefined symbol: apr_strtoff in
# ftp_commands.o
APR 0.9.x seems to lack of apr_strtoff() ....
should we backport this?
I found that f.e. 2.0.x mod_(mem_)cache has this rewrite:
#if 0
char *errp;
if (apr_strtoff(&size, cl, &errp, 10) || *errp || size < 0) {
cl = NULL; /* parse error, see next 'if' block */
}
#else
size = apr_atoi64(cl);
if (size < 0) {
cl = NULL;
}
#endif
or should we do similar in ftp_commands.c depending on MODULE_MAGIC_NUMBER ?
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Jorge Schrauwen wrote:
>
> Compiles fine on vs 2005 and default config works... however...
Sweet
> 1) I had to copy and rename libapr-1.lib and friends to without the -1 part.
> 2) I had to copy mod_log_config.h into mod_ftp's include dir since it
> wast in apache include dir... did a recompile of httpd and not there!
> so something is either wrong in the httpd makefile and it doesn't get
> copied or mod_ftp is looking for it in the wrong place. (in the end I
> found it in httpd-src/modules.
Both documented in README-FTP, thanks for the observation :)
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
> OK - here's my thought for 0.9.2 (not really a showstopper for this
> alpha release);
> * it's supposed to be as simple as copying over an existing httpd
> source tree. For win32, that means (minimum) you touch Apache.dsw
> and Makefile.win. Maybe ship those as a patch? It's 2 small adds
> each, so even without patch.exe it isn't going to be hard to do it.
> patch -p0 < build/win32-ftp-in-tree.patch -- and you are good to go.
> * out of tree on unix requires ./configure-apxs, so add a corresponding
> configure-win.bat to configure the mod_ftp.dsp (and example mod) to
> compile against a certain APACHE tree.
> Sound good?
+1
Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
> sweet! Let me please know how you will resolve this so that I can sync with NetWare installdev.
Crappy solution, I iterate the explicit list of includes just
like Makefile.in spells out.
Why these don't land in include/ during build is beyond me. Our
schema for building header files sucks :)
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
> Guenter Knauf wrote:
>> its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an
>> probably some more module headers are missing in the installed include
>> dir...
>> perhaps we should think of a subfolder 'module_headers' or such, and move
>> these headers to there, or at least create such a folder with install and
>> copy the module headers there....
> Already fixed the Makefile.win and working on the installer changes to
> completely resolve this in 2.2.7/2.0.62.
sweet! Let me please know how you will resolve this so that I can sync with NetWare installdev.
thanks, Guen.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
> its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an probably some more module headers are missing in the installed include dir...
> perhaps we should think of a subfolder 'module_headers' or such, and move these headers to there, or at least create such a folder with install and copy the module headers there....
Already fixed the Makefile.win and working on the installer changes to
completely resolve this in 2.2.7/2.0.62.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Jorge Schrauwen <jo...@gmail.com>.
On 1/3/08, Guenter Knauf <fu...@apache.org> wrote:
> Hi,
> > No it didn't.
>
> > I got a few notes on this though:
> > 1) in the 2.0 tree is there a loggers subfolder in the source tree?
> > I'm not sure been a long time since I looked at it.
> yes.
> > 2) APACHE2_HOME points to the install dir of apache and not to the
> > source IIRC? so there wouldn't be a modules subfolder there anyway.
> sorry, yes, this only works for in-tree compile;
> somehow we have not thought yet about this;
> its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an probably some more module headers are missing in the installed include dir...
> perhaps we should think of a subfolder 'module_headers' or such, and move these headers to there, or at least create such a folder with install and copy the module headers there....
I see... thats a complicated problem then :(
maybe keep the same layout as the source?
include/ <- general files + apr (like it is now)
include/modules/logger
include/modules/xxx
to keep the organized?
Just wondering are big changes like that allowed on 2.2? or if this
gets correct only be in trunk?
>
> BTW. if you compiled with 2.0.x - how did you get around the missing apr_strtoff() issue then?
>
I didn't, I was just wondering if the source layout (aka having
modules/loggers) sub folder in the 2.0 source aswel. I can't remember
if it had.
> Guenter.
>
>
>
--
~Jorge
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Jorge Schrauwen <jo...@gmail.com>.
Sounds good to me.
I compiled a few 3rd party modules on windows and most are not intree
compiling.
So I don't see it as a big loss if mod_ftpd doesn't compile in tree on windows.
On Jan 5, 2008 8:36 PM, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> Guenter Knauf wrote:
> >
> >> I got a few notes on this though:
> >> 1) in the 2.0 tree is there a loggers subfolder in the source tree?
> >> I'm not sure been a long time since I looked at it.
> >> 2) APACHE2_HOME points to the install dir of apache and not to the
> >> source IIRC? so there wouldn't be a modules subfolder there anyway.
> > sorry, yes, this only works for in-tree compile;
> > somehow we have not thought yet about this;
> > its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an probably some more module headers are missing in the installed include dir...
> > perhaps we should think of a subfolder 'module_headers' or such, and move these headers to there, or at least create such a folder with install and copy the module headers there....
>
> OK - here's my thought for 0.9.2 (not really a showstopper for this
> alpha release);
>
> * it's supposed to be as simple as copying over an existing httpd
> source tree. For win32, that means (minimum) you touch Apache.dsw
> and Makefile.win. Maybe ship those as a patch? It's 2 small adds
> each, so even without patch.exe it isn't going to be hard to do it.
> patch -p0 < build/win32-ftp-in-tree.patch -- and you are good to go.
>
> * out of tree on unix requires ./configure-apxs, so add a corresponding
> configure-win.bat to configure the mod_ftp.dsp (and example mod) to
> compile against a certain APACHE tree.
>
> Sound good?
>
> Bill
>
>
--
~Jorge
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
>
>> I got a few notes on this though:
>> 1) in the 2.0 tree is there a loggers subfolder in the source tree?
>> I'm not sure been a long time since I looked at it.
>> 2) APACHE2_HOME points to the install dir of apache and not to the
>> source IIRC? so there wouldn't be a modules subfolder there anyway.
> sorry, yes, this only works for in-tree compile;
> somehow we have not thought yet about this;
> its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an probably some more module headers are missing in the installed include dir...
> perhaps we should think of a subfolder 'module_headers' or such, and move these headers to there, or at least create such a folder with install and copy the module headers there....
OK - here's my thought for 0.9.2 (not really a showstopper for this
alpha release);
* it's supposed to be as simple as copying over an existing httpd
source tree. For win32, that means (minimum) you touch Apache.dsw
and Makefile.win. Maybe ship those as a patch? It's 2 small adds
each, so even without patch.exe it isn't going to be hard to do it.
patch -p0 < build/win32-ftp-in-tree.patch -- and you are good to go.
* out of tree on unix requires ./configure-apxs, so add a corresponding
configure-win.bat to configure the mod_ftp.dsp (and example mod) to
compile against a certain APACHE tree.
Sound good?
Bill
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
> No it didn't.
> I got a few notes on this though:
> 1) in the 2.0 tree is there a loggers subfolder in the source tree?
> I'm not sure been a long time since I looked at it.
yes.
> 2) APACHE2_HOME points to the install dir of apache and not to the
> source IIRC? so there wouldn't be a modules subfolder there anyway.
sorry, yes, this only works for in-tree compile;
somehow we have not thought yet about this;
its not only for mod_log_config.h , but also mod_dav.h, mod_proxy.h an probably some more module headers are missing in the installed include dir...
perhaps we should think of a subfolder 'module_headers' or such, and move these headers to there, or at least create such a folder with install and copy the module headers there....
BTW. if you compiled with 2.0.x - how did you get around the missing apr_strtoff() issue then?
Guenter.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
> Hi Jorge,
>
>> 2) I had to copy mod_log_config.h into mod_ftp's include dir since it
>> wast in apache include dir... did a recompile of httpd and not there!
>> so something is either wrong in the httpd makefile and it doesn't get
>> copied or mod_ftp is looking for it in the wrong place. (in the end I
>> found it in httpd-src/modules.
> can you please test if the attached diff fixes this second issue?
That would work for an in-tree build (sort of - .lib's are now in another
place). I'm fine on adopting this as part of the in-tree, out-of-tree
changes I'm working on for win32.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Jorge Schrauwen <jo...@gmail.com>.
Hi Guenter,
No it didn't.
I got a few notes on this though:
1) in the 2.0 tree is there a loggers subfolder in the source tree?
I'm not sure been a long time since I looked at it.
2) APACHE2_HOME points to the install dir of apache and not to the
source IIRC? so there wouldn't be a modules subfolder there anyway.
~ Jorge
On Jan 3, 2008 2:35 PM, Guenter Knauf <fu...@apache.org> wrote:
> Hi Jorge,
>
> > 2) I had to copy mod_log_config.h into mod_ftp's include dir since it
> > wast in apache include dir... did a recompile of httpd and not there!
> > so something is either wrong in the httpd makefile and it doesn't get
> > copied or mod_ftp is looking for it in the wrong place. (in the end I
> > found it in httpd-src/modules.
> can you please test if the attached diff fixes this second issue?
>
> Guenter.
>
>
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Guenter Knauf <fu...@apache.org>.
Hi Jorge,
> 2) I had to copy mod_log_config.h into mod_ftp's include dir since it
> wast in apache include dir... did a recompile of httpd and not there!
> so something is either wrong in the httpd makefile and it doesn't get
> copied or mod_ftp is looking for it in the wrong place. (in the end I
> found it in httpd-src/modules.
can you please test if the attached diff fixes this second issue?
Guenter.
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by Jorge Schrauwen <jo...@gmail.com>.
On Jan 3, 2008 4:29 AM, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> mod_ftp fans;
> [ ] -1 for any release of 0.9.1
> [X] +1 to release as 0.9.1-alpha
> [ ] +1 to release as 0.9.1-beta
> [ ] +1 to release as 0.9.1-beta, and ready to tag GA (1.0.0)
Compiles fine on vs 2005 and default config works... however...
1) I had to copy and rename libapr-1.lib and friends to without the -1 part.
2) I had to copy mod_log_config.h into mod_ftp's include dir since it
wast in apache include dir... did a recompile of httpd and not there!
so something is either wrong in the httpd makefile and it doesn't get
copied or mod_ftp is looking for it in the wrong place. (in the end I
found it in httpd-src/modules.
Didn't do a decent test with the exames but sample conf works so I say alpha
--
~Jorge
Re: [VOTE] initial release of httpd-mod_ftp-0.9.1
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Please fetch up the newly prepared httpd-mod_ftp-0.9.1.tar.gz, or the
> win32/netware/os2 suitable package httpd-mod_ftp-0.9.1-crlf.zip (and
> their md5/asc sigs) from:
>
> [X] +1 to release as 0.9.1-alpha
If the announce states this is an alpha for httpd-2.2 I don't see any
significant issues. The crazy rate that I'm patching trunk/ isn't
related to any flaw, but it's leading to the goal of named virtual hosts
by USER name (e.g. will@apache.org -> Username: will, Host: apache.org).
If Guenter's suggestion about STATUS seeming odd, and we agree to drop the
STATUS-FTP file from the tarball, I'm happy to reroll before posting up
announce and 0.9.1 alpha. The only change I'd back is removing STATUS
since it's how we package httpd-x.x.tar.gz.
Need 2 +1's beyond my own to remove STATUS-FTP from the packages.
I'll call and count the vote this evening.
Bill
---------------------------------------------------------------------
To unsubscribe, e-mail: testers-unsubscribe@httpd.apache.org
For additional commands, e-mail: testers-help@httpd.apache.org