You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@druid.apache.org by Eyal Yurman <ey...@verizonmedia.com.INVALID> on 2019/01/29 22:43:38 UTC

Contributing an extension

Hi,

This pr is waiting for a few months for review:
https://github.com/apache/incubator-druid/pull/6430
https://github.com/apache/incubator-druid/issues/6320

So far only one reviewer (@b-slim) was kind enough to start looking at it.

Since this is an contrib extension, it is not really blocking me (It is in
production for the past 2 years...). But I have noticed a large number of
users commenting/emojiing the PR/issue, so I think the community would
appreciate it if this would be released.

Since this is an extension, would you say it's better if I release it in my
company's own repository, or should I continue to request review and merge?

Thanks!

Eyal.

Re: Contributing an extension

Posted by Eyal Yurman <ey...@verizonmedia.com.INVALID>.

Thanks!!

Btw, sorry for the dual messages, the mail server blocked my first one and
after I resubscribed to the list, it has sent it :)


On Tue, Jan 29, 2019, 18:26 Jonathan Wei <jonwei@apache.org wrote:

> Hi Eyal,
>
> Thanks for the contrib, I'll have some time to start reviewing in the next
> week or two. It seems like a cool feature with interest from users, so I'd
> lean towards keeping it open for review/merge.
>
> Best,
> Jon
>
> On Tue, Jan 29, 2019 at 5:29 PM Eyal Yurman
> <ey...@verizonmedia.com.invalid> wrote:
>
> > Hi,
> >
> > This pr is waiting for a few months for review:
> > https://github.com/apache/incubator-druid/pull/6430
> > https://github.com/apache/incubator-druid/issues/6320
> >
> > So far only one reviewer (@b-slim) was kind enough to start looking at
> it.
> >
> > Since this is an contrib extension, it is not really blocking me (It is
> in
> > production for the past 2 years...). But I have noticed a large number of
> > users commenting/emojiing the PR/issue, so I think the community would
> > appreciate it if this would be released.
> >
> > Since this is an extension, would you say it's better if I release it in
> my
> > company's own repository, or should I continue to request review and
> merge?
> >
> > Thanks!
> >
> > Eyal.
> >
>

Re: Contributing an extension

Posted by Jonathan Wei <jo...@apache.org>.

Hi Eyal,

Thanks for the contrib, I'll have some time to start reviewing in the next
week or two. It seems like a cool feature with interest from users, so I'd
lean towards keeping it open for review/merge.

Best,
Jon

On Tue, Jan 29, 2019 at 5:29 PM Eyal Yurman
<ey...@verizonmedia.com.invalid> wrote:

> Hi,
>
> This pr is waiting for a few months for review:
> https://github.com/apache/incubator-druid/pull/6430
> https://github.com/apache/incubator-druid/issues/6320
>
> So far only one reviewer (@b-slim) was kind enough to start looking at it.
>
> Since this is an contrib extension, it is not really blocking me (It is in
> production for the past 2 years...). But I have noticed a large number of
> users commenting/emojiing the PR/issue, so I think the community would
> appreciate it if this would be released.
>
> Since this is an extension, would you say it's better if I release it in my
> company's own repository, or should I continue to request review and merge?
>
> Thanks!
>
> Eyal.
>