You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/30 00:17:30 UTC
[GitHub] [airflow] fredthomsen opened a new pull request #15605: Update SimpleHttpOperator to take auth type object
fredthomsen opened a new pull request #15605:
URL: https://github.com/apache/airflow/pull/15605
A requests.auth.AuthBase object is not passed through from the
SimpleHttpOperator to the underlying HttpHook, thus if you want to
use the SimpleHttpOperator but have a custom auth_type, you must
inherit from it and override the execute method. Update the operator
to take this parameter.
Seems like a small oversight that existing tests should cover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fredthomsen commented on a change in pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
fredthomsen commented on a change in pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#discussion_r627464307
##########
File path: airflow/providers/http/operators/http.py
##########
@@ -84,6 +88,7 @@ def __init__(
extra_options: Optional[Dict[str, Any]] = None,
http_conn_id: str = 'http_default',
log_response: bool = False,
+ auth_type: Type(AuthBase) = HTTPBasicAuth,
Review comment:
Actually, mypy does not complain about this interestingly enough. I was surprised. However, I did not re-run the provider tests on this annotation update and they do indeed fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#discussion_r624435464
##########
File path: airflow/providers/http/operators/http.py
##########
@@ -84,6 +88,7 @@ def __init__(
extra_options: Optional[Dict[str, Any]] = None,
http_conn_id: str = 'http_default',
log_response: bool = False,
+ auth_type: Any = HTTPBasicAuth,
Review comment:
```suggestion
auth_type: Type[AuthBase] = HTTPBasicAuth,
```
See https://docs.python-requests.org/en/master/user/authentication/#new-forms-of-authentication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fredthomsen edited a comment on pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
fredthomsen edited a comment on pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#issuecomment-829717194
This does address issue #259, although given it's age, I doubt that is relevant now, which is why I did not include it above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fredthomsen commented on pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
fredthomsen commented on pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#issuecomment-829717194
This does address issue #259, although given it's age, I doubt that is relevant now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#issuecomment-829711871
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fredthomsen commented on a change in pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
fredthomsen commented on a change in pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#discussion_r624499404
##########
File path: airflow/providers/http/operators/http.py
##########
@@ -84,6 +88,7 @@ def __init__(
extra_options: Optional[Dict[str, Any]] = None,
http_conn_id: str = 'http_default',
log_response: bool = False,
+ auth_type: Any = HTTPBasicAuth,
Review comment:
Woops done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#discussion_r627143921
##########
File path: airflow/providers/http/operators/http.py
##########
@@ -84,6 +88,7 @@ def __init__(
extra_options: Optional[Dict[str, Any]] = None,
http_conn_id: str = 'http_default',
log_response: bool = False,
+ auth_type: Type(AuthBase) = HTTPBasicAuth,
Review comment:
```suggestion
auth_type: Type[AuthBase] = HTTPBasicAuth,
```
I’m surprised Mypy does not complain about this. Is this even legal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #15605:
URL: https://github.com/apache/airflow/pull/15605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#issuecomment-834448498
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fredthomsen commented on pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
fredthomsen commented on pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#issuecomment-834640032
>
>
> @fredthomsen Could you rebase please?
@ashb done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #15605: Update SimpleHttpOperator to take auth type object
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #15605:
URL: https://github.com/apache/airflow/pull/15605#issuecomment-834477450
@fredthomsen Could you rebase please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org