[jira] [Commented] (COUCHDB-2561) Make config API consistent

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526437#comment-15526437 ] 

ASF GitHub Bot commented on COUCHDB-2561:
-----------------------------------------

GitHub user rnewson opened a pull request:

    https://github.com/apache/couchdb-chttpd/pull/141

    Fix SSL defaults

    Three properties had their defaults changed to a value that
    couch_util:parse_terms throws up on.
    
    "nil" was changed to undefined in COUCHDB-2561 as part of normalising
    the config API. The change from list to atom was a mistake.
    
    COUCHDB-3162

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-chttpd 3162-ssl-defaults

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-chttpd/pull/141.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #141
    
----
commit f1d0c5dc8e9ea8c639d39ff63001f3925d6786e8
Author: Robert Newson <rn...@apache.org>
Date:   2016-09-27T15:15:44Z

    Fix SSL defaults
    
    Three properties had their defaults changed to a value that
    couch_util:parse_terms throws up on.
    
    "nil" was changed to undefined in COUCHDB-2561 as part of normalising
    the config API. The change from list to atom was a mistake.
    
    COUCHDB-3162

----


> Make config API consistent
> --------------------------
>
>                 Key: COUCHDB-2561
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2561
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>            Reporter: ILYA
>            Assignee: ILYA
>             Fix For: 2.0.0
>
>
> There are 2 problems with API which need to be fixed.
> 1) Mix of message driven and callback driven
> API for config_listener is hard to use. 
> In particular there is a gen_event_EXIT
> message which is sent to the process which called config:listen_for_changes.
> This makes API unsuitable for use in the context of a supervisor. Since supervisors do not support handling of arbitrary messages. This message also causing problems for test suite.
> This message could be substituted with 
> a call to Module:handle_config_stop(Pid, Reason, State).
> 2) Since for section, key, value we only support lists but not arbitrary terms. More strick guards are needed to make sure the caller of the API fails with badarg 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)