You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/30 01:11:08 UTC

[GitHub] [iceberg] rdblue commented on pull request #1326: Hive: Filter pushdown

rdblue commented on pull request #1326:
URL: https://github.com/apache/iceberg/pull/1326#issuecomment-683362629


   @cmathiesen, I had a closer look at the date/time and decimal conversion and found that there were a few bugs. I opened https://github.com/ExpediaGroup/iceberg/pull/16 with the fixes for those problems. Could you review that and merge?
   
   One major take-away was that it is not safe to call `Timestamp.toLocalDate` for conversion because that conversion is in local time, not UTC. FYI @massdosage, @rdsr, and @guilload.
   
   This also hits [HIVE-19726](https://issues.apache.org/jira/browse/HIVE-19726), which erases milliseconds. It was fixed in Hive 2.4.0, but I've added a work-around in the PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org