[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2115: fix: after enable redirect HTTPS, websocket form field disappeared

[GitBox <gi...@apache.org>]

liuxiran commented on a change in pull request #2115:
URL: https://github.com/apache/apisix-dashboard/pull/2115#discussion_r700930038



##########
File path: web/cypress/integration/route/create-edit-route-with-redirect-plugin.spec.js
##########
@@ -61,8 +61,8 @@ context('Create Edit and Delete Route with redirect plugin', () => {
     cy.get(selector.customRedirectLabel).should('be.visible');
     cy.get(selector.customRedirectUrI).should('be.visible');
     cy.get(selector.customRedirectCode).should('be.visible');
-    cy.get(selector.webSocketSelector).should('not.exist');
-    cy.get(selector.enable_websocket_button).should('not.exist');
+    cy.get(selector.webSocketSelector).should('exist');
+    cy.get(selector.enable_websocket_button).should('exist');

Review comment:
       would you please add an assertion to test enable websocket succseefully and check the info in configure view? @LiteSun 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org