[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6690: Quota enable config to user/domain scope

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6690:
URL: https://github.com/apache/cloudstack/pull/6690#discussion_r959239390


##########
framework/quota/src/main/java/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java:
##########
@@ -36,7 +38,15 @@ public class QuotaAccountDaoImpl extends GenericDaoBase<QuotaAccountVO, Long> im
 
     @Override
     public List<QuotaAccountVO> listAllQuotaAccount() {
-        return listAllQuotaAccount(null, null).first();
+        List<QuotaAccountVO> accountsWithQuotaEnabled = new ArrayList<>();
+        for (QuotaAccountVO account : listAllQuotaAccount(null, null).first()) {
+            if (getQuotaAccountEnabled(account.getAccountId())) {

Review Comment:
   ```suggestion
               if (Boolean.TRUE.equals(getQuotaAccountEnabled(account.getAccountId()))) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org