You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/02/01 00:57:54 UTC

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20433#discussion_r165233944
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala ---
    @@ -561,8 +561,11 @@ class ExpressionParserSuite extends PlanTest {
           Literal(CalendarInterval.fromSingleUnitString(u, s))
         }
     
    -    // Empty interval statement
    -    intercept("interval", "at least one time unit should be given for interval literal")
    --- End diff --
    
    we shall still check the empty interval statement, now it shall produce a different error message?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org