You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/09/04 07:48:44 UTC
Review Request 71430: Included new Python CLI in distribution tarball.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71430/
-----------------------------------------------------------
Review request for mesos and Benno Evers.
Bugs: MESOS-9958
https://issues.apache.org/jira/browse/MESOS-9958
Repository: mesos
Description
-------
Included new Python CLI in distribution tarball.
Diffs
-----
src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
Diff: https://reviews.apache.org/r/71430/diff/1/
Testing
-------
* confirmed that the new CLI source files are contained in the distribution tarball
* one can currently still not run `make distcheck` with `--enable-new-cli` since the Mesos lib egg build process puts output files into the source dir
Thanks,
Benjamin Bannier
Re: Review Request 71430: Included new Python CLI in distribution
tarball.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71430/#review217562
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71430]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 4, 2019, 7:48 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71430/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2019, 7:48 a.m.)
>
>
> Review request for mesos and Benno Evers.
>
>
> Bugs: MESOS-9958
> https://issues.apache.org/jira/browse/MESOS-9958
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included new Python CLI in distribution tarball.
>
>
> Diffs
> -----
>
> src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
>
>
> Diff: https://reviews.apache.org/r/71430/diff/1/
>
>
> Testing
> -------
>
> * confirmed that the new CLI source files are contained in the distribution tarball
> * one can currently still not run `make distcheck` with `--enable-new-cli` since the Mesos lib egg build process puts output files into the source dir
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71430: Included new Python CLI in distribution
tarball.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71430/#review217789
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Sept. 4, 2019, 7:48 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71430/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2019, 7:48 a.m.)
>
>
> Review request for mesos, Benno Evers and Till Toenshoff.
>
>
> Bugs: MESOS-9958
> https://issues.apache.org/jira/browse/MESOS-9958
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included new Python CLI in distribution tarball.
>
>
> Diffs
> -----
>
> src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
>
>
> Diff: https://reviews.apache.org/r/71430/diff/1/
>
>
> Testing
> -------
>
> * confirmed that the new CLI source files are contained in the distribution tarball
> * one can currently still not run `make distcheck` with `--enable-new-cli` since the Mesos lib egg build process puts output files into the source dir
>
>
> Thanks,
>
> Benjamin Bannier
>
>