You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/14 06:22:01 UTC

[GitHub] [spark] viirya commented on pull request #29018: [SPARK-32202][ML][WIP] tree models auto infer compact integer type

viirya commented on pull request #29018:
URL: https://github.com/apache/spark/pull/29018#issuecomment-657993178


   Despite the significant memory save, I'm also not sure how often memory is an issue when training the model. I guess CPU is more important here. This win only happens when maxBins is less, so sounds it is for limited cases, but the perf regression happens for all cases?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org