[GitHub] [shardingsphere] tuichenchuxin commented on a change in pull request #14988: support encrypt column config data type

[GitBox <gi...@apache.org>]

tuichenchuxin commented on a change in pull request #14988:
URL: https://github.com/apache/shardingsphere/pull/14988#discussion_r790250759



##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-api/src/main/java/org/apache/shardingsphere/encrypt/api/config/rule/EncryptColumnRuleConfiguration.java
##########
@@ -18,22 +18,45 @@
 package org.apache.shardingsphere.encrypt.api.config.rule;
 
 import lombok.Getter;
-import lombok.RequiredArgsConstructor;
 
 /**
  * Encrypt column rule configuration.
  */
-@RequiredArgsConstructor
 @Getter
 public final class EncryptColumnRuleConfiguration {
     
     private final String logicColumn;
     
+    private final String logicDataType;
+    
     private final String cipherColumn;
     
+    private final String cipherDataType;
+    
     private final String assistedQueryColumn;
     
+    private final String assistedQueryDataType;
+    
     private final String plainColumn;
     
+    private final String plainDataType;
+    
     private final String encryptorName;
+    
+    public EncryptColumnRuleConfiguration(final String logicColumn, final String cipherColumn, final String assistedQueryColumn, final String plainColumn, final String encryptorName) {
+        this(logicColumn, null, cipherColumn, null, assistedQueryColumn, null, plainColumn, null, encryptorName);
+    }
+    
+    public EncryptColumnRuleConfiguration(final String logicColumn, final String logicDataType, final String cipherColumn, final String cipherDataType, final String assistedQueryColumn, 
+                                          final String assistedQueryDataType, final String plainColumn, final String plainDataType, final String encryptorName) {
+        this.logicColumn = logicColumn;
+        this.logicDataType = logicDataType;
+        this.cipherColumn = cipherColumn;
+        this.cipherDataType = cipherDataType;
+        this.assistedQueryColumn = assistedQueryColumn;
+        this.assistedQueryDataType = assistedQueryDataType;
+        this.plainColumn = plainColumn;
+        this.plainDataType = plainDataType;
+        this.encryptorName = encryptorName;
+    }

Review comment:
       Yes, I'll replace the construct with @RequiredArgsConstructor.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org