You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2023/04/25 13:25:04 UTC
[commons-numbers] 04/07: PMD fix: Use final
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit 0374cd29c02e780156cb31ecc99b7536fe64a452
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Apr 25 14:04:57 2023 +0100
PMD fix: Use final
---
.../src/main/java/org/apache/commons/numbers/core/Norm.java | 8 ++++----
.../src/main/java/org/apache/commons/numbers/core/Sum.java | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Norm.java b/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Norm.java
index 98de568f..e4872643 100644
--- a/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Norm.java
+++ b/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Norm.java
@@ -306,7 +306,7 @@ public enum Norm {
double comp = 0d;
// add scaled x
- double sx = xabs * scale;
+ final double sx = xabs * scale;
final double px = sx * sx;
comp += ExtendedPrecision.squareLowUnscaled(sx, px);
final double sumPx = sum + px;
@@ -314,7 +314,7 @@ public enum Norm {
sum = sumPx;
// add scaled y
- double sy = yabs * scale;
+ final double sy = yabs * scale;
final double py = sy * sy;
comp += ExtendedPrecision.squareLowUnscaled(sy, py);
final double sumPy = sum + py;
@@ -371,7 +371,7 @@ public enum Norm {
double comp = 0d;
// add scaled x
- double sx = xabs * scale;
+ final double sx = xabs * scale;
final double px = sx * sx;
comp += ExtendedPrecision.squareLowUnscaled(sx, px);
final double sumPx = sum + px;
@@ -379,7 +379,7 @@ public enum Norm {
sum = sumPx;
// add scaled y
- double sy = yabs * scale;
+ final double sy = yabs * scale;
final double py = sy * sy;
comp += ExtendedPrecision.squareLowUnscaled(sy, py);
final double sumPy = sum + py;
diff --git a/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Sum.java b/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Sum.java
index 8953efd1..05ebecfe 100644
--- a/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Sum.java
+++ b/commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Sum.java
@@ -121,7 +121,7 @@ public final class Sum
* @return this instance.
*/
public Sum add(final double... terms) {
- for (double t : terms) {
+ for (final double t : terms) {
add(t);
}