You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by eminency <gi...@git.apache.org> on 2015/01/08 17:30:10 UTC

[GitHub] tajo pull request: TAJO-1258: Close() for classes derived from Fil...

GitHub user eminency opened a pull request:

    https://github.com/apache/tajo/pull/340

    TAJO-1258: Close() for classes derived from FileAppender should be robust

    TAJO-1258 branch is newly created and PR is re-created.
    
    I modified it using IOUtils.cleanup.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eminency/tajo TAJO-1258

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #340
    
----
commit c0f3f4f0f996352737ffa40e428437d77f1a2cd2
Author: Jongyoung Park <em...@gmail.com>
Date:   2015-01-08T16:22:44Z

    IOUtils.cleanup is used instead of direct close() in appenders.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1258: Close() for classes derived from Fil...

Posted by jinossy <gi...@git.apache.org>.

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/340#issuecomment-69210267
  
    +1 Looks good to me.
    I'll commit it after the TravisCI finished


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1258: Close() for classes derived from Fil...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/340


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1258: Close() for classes derived from Fil...

Posted by jinossy <gi...@git.apache.org>.

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/340#issuecomment-69206083
  
    Thank you for your contribution.
     I'm reviewing the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---