You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/04/08 12:37:51 UTC

[GitHub] [systemml] j143 opened a new pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files

j143 opened a new pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files
URL: https://github.com/apache/systemml/pull/880
 
 
   This PR is for discussion and work related to few more add the to be ignored files.
   Configuration files related to 
   1. maven build
     - [ ] dependency-reduced-pom.xml
     - [ ] temp/
   2. intellij
     - [ ] .idea/
   
   Feel free to add more extensions. thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [systemml] asfgit closed pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files
URL: https://github.com/apache/systemml/pull/880
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [systemml] Baunsgaard commented on a change in pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files
URL: https://github.com/apache/systemml/pull/880#discussion_r405495380
 
 

 ##########
 File path: .gitignore
 ##########
 @@ -9,7 +11,16 @@ Gemfile.lock
 .settings/
 .vscode/
 
-## Inproper copy when switching branch
+## IntelliJ
+
+.idea/
+
+## Improper copy when switching branch
 
 Review comment:
   thanks for the correction :+1:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [systemml] Baunsgaard commented on a change in pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files
URL: https://github.com/apache/systemml/pull/880#discussion_r405495838
 
 

 ##########
 File path: .gitignore
 ##########
 @@ -1,3 +1,5 @@
+## Jekyll build files
 
 Review comment:
   It is not just Jekyll, it is also artifacts from mvn.
   
   maybe split it up, if you want to mark it as such.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [systemml] Baunsgaard commented on a change in pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #880: [MINOR] [DOC] skip IntelliJ, and mvn build config files
URL: https://github.com/apache/systemml/pull/880#discussion_r405495411
 
 

 ##########
 File path: .gitignore
 ##########
 @@ -9,7 +11,16 @@ Gemfile.lock
 .settings/
 .vscode/
 
-## Inproper copy when switching branch
+## IntelliJ
+
+.idea/
+
+## Improper copy when switching branch
+
+src/
+
+## Maven build files
 
 target/
-src/ 
\ No newline at end of file
+temp/
+dependency-reduced-pom.xml
 
 Review comment:
   dependency-reduced-pom is gitignored on main branch yes, but i don't think it is removed completely. I would suggest you remove it from your fork, unless it is needed for something.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services