You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "raju-balpande (via GitHub)" <gi...@apache.org> on 2024/03/19 10:41:04 UTC
[PR] HDDS-10309. Speed up TestSnapshotDeletingService [ozone]
raju-balpande opened a new pull request, #6403:
URL: https://github.com/apache/ozone/pull/6403
## What changes were proposed in this pull request?
Speed up TestSnapshotDeletingService
The time span is improved to 250.118 seconds from 321.147 seconds earlier.
https://github.com/raju-balpande/apache_ozone/actions/runs/8339044173/job/22820842037
Please describe your PR in detail:
We have managed the cluster creation part to be executed once.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10309?
## How was this patch tested?
Tested each method independently and in sequence locally and Tested the sequence in Ci https://github.com/raju-balpande/apache_ozone/actions/runs/8339044173/job/22820842037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10309. Speed up TestSnapshotDeletingService [ozone]
Posted by "raju-balpande (via GitHub)" <gi...@apache.org>.
raju-balpande commented on code in PR #6403:
URL: https://github.com/apache/ozone/pull/6403#discussion_r1567334826
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java:
##########
@@ -189,10 +206,16 @@ public void testMultipleSnapshotKeyReclaim() throws Exception {
// verify the cache of purged snapshot
// /vol1/bucket2/bucket2snap1 has been cleaned up from cache map
assertEquals(2, om.getOmSnapshotManager().getSnapshotCacheSize());
+ //clean data
+ // // cleaning up the data
Review Comment:
Done. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10309. Speed up TestSnapshotDeletingService [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on code in PR #6403:
URL: https://github.com/apache/ozone/pull/6403#discussion_r1562980561
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java:
##########
@@ -189,10 +206,16 @@ public void testMultipleSnapshotKeyReclaim() throws Exception {
// verify the cache of purged snapshot
// /vol1/bucket2/bucket2snap1 has been cleaned up from cache map
assertEquals(2, om.getOmSnapshotManager().getSnapshotCacheSize());
+ //clean data
+ // // cleaning up the data
Review Comment:
nit: can you please fix the duplicate comments?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java:
##########
@@ -81,8 +90,11 @@ public class TestSnapshotDeletingService {
private static final String VOLUME_NAME = "vol1";
private static final String BUCKET_NAME_ONE = "bucket1";
private static final String BUCKET_NAME_TWO = "bucket2";
+ private static final String BUCKET_NAME_FSO = "bucketfso";
+
+ private boolean runIndividualTest = true;
Review Comment:
Why do you need `runIndividualTest` if tests are running in order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10309. Speed up TestSnapshotDeletingService [ozone]
Posted by "raju-balpande (via GitHub)" <gi...@apache.org>.
raju-balpande commented on code in PR #6403:
URL: https://github.com/apache/ozone/pull/6403#discussion_r1567305652
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java:
##########
@@ -81,8 +90,11 @@ public class TestSnapshotDeletingService {
private static final String VOLUME_NAME = "vol1";
private static final String BUCKET_NAME_ONE = "bucket1";
private static final String BUCKET_NAME_TWO = "bucket2";
+ private static final String BUCKET_NAME_FSO = "bucketfso";
+
+ private boolean runIndividualTest = true;
Review Comment:
By this check, I am making sure that the If anyone just want to run a single method it shall work for him.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10309. Speed up TestSnapshotDeletingService [ozone]
Posted by "raju-balpande (via GitHub)" <gi...@apache.org>.
raju-balpande commented on PR #6403:
URL: https://github.com/apache/ozone/pull/6403#issuecomment-2025683196
> Thanks @raju-balpande for the patch.
>
> Is it possible to create a separate bucket for each of the tests? Rather than using the order of tests.
>
> @aswinshakil please take a look as well.
I tried removing order but it involves lot of cleaning of data and/or considering previous records for comparison and hence the code complexity will get increased.
If we go with specified order it works with very minimal data cleanups.
Secondly, I ensured that If we run a single method then also it works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10309. Speed up TestSnapshotDeletingService [ozone]
Posted by "raju-balpande (via GitHub)" <gi...@apache.org>.
raju-balpande commented on PR #6403:
URL: https://github.com/apache/ozone/pull/6403#issuecomment-2019980794
Can this be reviewed please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10309. Speed up TestSnapshotDeletingService [ozone]
Posted by "raju-balpande (via GitHub)" <gi...@apache.org>.
raju-balpande closed pull request #6403: HDDS-10309. Speed up TestSnapshotDeletingService
URL: https://github.com/apache/ozone/pull/6403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org