You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2012/09/20 11:25:09 UTC
[jira] [Created] (WICKET-4773) ComponentFeedbackPanel broken under
Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
Dan Haywood created WICKET-4773:
-----------------------------------
Summary: ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
Key: WICKET-4773
URL: https://issues.apache.org/jira/browse/WICKET-4773
Project: Wicket
Issue Type: Bug
Affects Versions: 6.0.0
Reporter: Dan Haywood
Test case created on github.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4773) ComponentFeedbackPanel broken under
Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij resolved WICKET-4773.
-------------------------------------
Resolution: Fixed
The code that clears the reporter was added long ago for WICKET-2384 to prevent a memory leak. I'm not sure if this is still needed, but it seems better to at least not clear reporter until the message is rendered.
> ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-4773
> URL: https://issues.apache.org/jira/browse/WICKET-4773
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 6.0.0
> Reporter: Dan Haywood
> Assignee: Emond Papegaaij
> Fix For: 6.1.0
>
>
> Test case created on github, see https://github.com/danhaywood/wicket-4773
> browse to http://localhost:8080/wicket-examples/forminput and follow the instructions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4773) ComponentFeedbackPanel broken under
Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4773:
------------------------------------
Fix Version/s: 6.1.0
> ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-4773
> URL: https://issues.apache.org/jira/browse/WICKET-4773
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 6.0.0
> Reporter: Dan Haywood
> Fix For: 6.1.0
>
>
> Test case created on github, see https://github.com/danhaywood/wicket-4773
> browse to http://localhost:8080/wicket-examples/forminput and follow the instructions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4773) ComponentFeedbackPanel broken
under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459485#comment-13459485 ]
Dan Haywood commented on WICKET-4773:
-------------------------------------
The issue is that the reporter on the FeedbackMessage is set to null when detached after the first request; this means that the ComponentFeedbackPanel's filter never locates the message on the rendering in the second request
> ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-4773
> URL: https://issues.apache.org/jira/browse/WICKET-4773
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 6.0.0
> Reporter: Dan Haywood
>
> Test case created on github, see https://github.com/danhaywood/wicket-4773
> browse to http://localhost:8080/wicket-examples/forminput and follow the instructions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4773) ComponentFeedbackPanel broken under
Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij reassigned WICKET-4773:
---------------------------------------
Assignee: Emond Papegaaij
> ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-4773
> URL: https://issues.apache.org/jira/browse/WICKET-4773
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 6.0.0
> Reporter: Dan Haywood
> Assignee: Emond Papegaaij
> Fix For: 6.1.0
>
>
> Test case created on github, see https://github.com/danhaywood/wicket-4773
> browse to http://localhost:8080/wicket-examples/forminput and follow the instructions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4773) ComponentFeedbackPanel broken under
Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated WICKET-4773:
--------------------------------
Description:
Test case created on github, see https://github.com/danhaywood/wicket-4773
browse to http://localhost:8080/wicket-examples/forminput and follow the instructions.
was:Test case created on github.
> ComponentFeedbackPanel broken under Wicket 6.0.0 when RenderStrategy.REDIRECT_TO_RENDER
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-4773
> URL: https://issues.apache.org/jira/browse/WICKET-4773
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 6.0.0
> Reporter: Dan Haywood
>
> Test case created on github, see https://github.com/danhaywood/wicket-4773
> browse to http://localhost:8080/wicket-examples/forminput and follow the instructions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira