You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/09/14 10:30:25 UTC
[GitHub] carbondata pull request #2720: [WIP] Write is_sorter in footer for compactio...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2720
[WIP] Write is_sorter in footer for compaction
carbondata.thrift is modified to add is_sorted in footer to indicate whether the file is sorted, which will help compaction to decide whether to use merge sort or not
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata write_is_sort_in_footer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2720
----
commit d5556989b2dbb3a65ba27b7ac561562c9e07917e
Author: Jacky Li <ja...@...>
Date: 2018-09-14T10:28:25Z
write is_sorter in footer
----
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/456/
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8526/
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/338/
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/290/
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2720
@jackylk Please rebase it.
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/283/
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2720
@jackylk Please fix the test , i will merge it
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/515/
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/465/
---
[GitHub] carbondata pull request #2720: [CARBONDATA-2935] Write is_sorter in footer f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2720
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8585/
---
[GitHub] carbondata pull request #2720: [WIP] Write is_sorter in footer for compactio...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2720#discussion_r217669998
--- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
@@ -324,7 +324,7 @@ public void initializeWriter() throws CarbonDataWriterException {
/**
* This method will write metadata at the end of file file format in thrift format
*/
- protected abstract void writeBlockletInfoToFile() throws CarbonDataWriterException;
--- End diff --
this method name is wrong earlier
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2720
LGTM
---
[GitHub] carbondata issue #2720: [CARBONDATA-2935] Write is_sorter in footer for comp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2720
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8535/
---