You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "michaelsembwever (via GitHub)" <gi...@apache.org> on 2023/07/20 08:17:40 UTC
[GitHub] [cassandra] michaelsembwever opened a new pull request, #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
michaelsembwever opened a new pull request, #2502:
URL: https://github.com/apache/cassandra/pull/2502
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269210554
##########
.build/run-tests.sh:
##########
@@ -16,10 +16,8 @@
# limitations under the License.
#
-# Wrapper script for running a split chunk of an ant test target
+# Wrapper script for running a split or regexp of tests (excluding python dtests)
Review Comment:
python dtests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269212551
##########
.build/run-tests.sh:
##########
@@ -16,10 +16,8 @@
# limitations under the License.
#
-# Wrapper script for running a split chunk of an ant test target
+# Wrapper script for running a split or regexp of tests (excluding python dtests)
Review Comment:
vs jvm dtests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269212194
##########
.build/run-python-dtests.sh:
##########
@@ -158,7 +170,7 @@ popd >/dev/null
#
################################
-rm -rf ${TMPDIR}
+rm -rf "/tmp/run-python-dtest.${TMPDIR/\/tmp\/run-python-dtest./}"
Review Comment:
prevents something dangerous, like `rm -rf /home`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269210898
##########
.build/run-tests.sh:
##########
@@ -39,7 +37,7 @@ command -v git >/dev/null 2>&1 || { echo >&2 "git needs to be installed"; exit 1
# help
if [ "$#" -lt 1 ] || [ "$#" -gt 2 ] || [ "$1" == "-h" ]; then
echo ""
- echo "Usage: run-tests.sh target [split_chunk|test_regexp]"
+ echo "Usage: run-tests.sh test_type [split_chunk|test_regexp]"
Review Comment:
same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269211229
##########
.build/docker/run-tests.sh:
##########
@@ -27,7 +27,7 @@
# help
if [ "$#" -lt 1 ] || [ "$#" -gt 3 ] || [ "$1" == "-h" ]; then
echo ""
- echo "Usage: run-tests.sh target [split_chunk|test_regexp] [java_version]"
+ echo "Usage: run-tests.sh test_type [split_chunk|test_regexp] [java_version]"
Review Comment:
yes, i've been thinking about this, but don't have a clear way. lhf to leave.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269205036
##########
.build/run-python-dtests.sh:
##########
@@ -16,17 +16,25 @@
# limitations under the License.
#
-# Wrapper script for running a split chunk of a pytest run of cassandra-dtest
+# Wrapper script for running a split or regexp of a pytest run from cassandra-dtest
#
-# Usage: dtest-python.sh target split_chunk
-# split_chunk formatted as "K/N" for the Kth chunk of N chunks
################################
#
# Prep
#
################################
+
+# help
+if [ "$#" -lt 1 ] || [ "$#" -gt 2 ] || [ "$1" == "-h" ]; then
+ echo ""
+ echo "Usage: run-python-dtest.sh test_type [split_chunk|test_regexp]"
Review Comment:
same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269202806
##########
.build/docker/run-tests.sh:
##########
@@ -27,7 +27,7 @@
# help
if [ "$#" -lt 1 ] || [ "$#" -gt 3 ] || [ "$1" == "-h" ]; then
echo ""
- echo "Usage: run-tests.sh target [split_chunk|test_regexp] [java_version]"
+ echo "Usage: run-tests.sh test_type [split_chunk|test_regexp] [java_version]"
Review Comment:
would be nice for the help message to include the valid test types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jacek-lewandowski commented on a diff in pull request #2502: Add dtest-upgrade-large test type for resource-intensive Python upgrade dtests
Posted by "jacek-lewandowski (via GitHub)" <gi...@apache.org>.
jacek-lewandowski commented on code in PR #2502:
URL: https://github.com/apache/cassandra/pull/2502#discussion_r1269209174
##########
.build/run-python-dtests.sh:
##########
@@ -158,7 +170,7 @@ popd >/dev/null
#
################################
-rm -rf ${TMPDIR}
+rm -rf "/tmp/run-python-dtest.${TMPDIR/\/tmp\/run-python-dtest./}"
Review Comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org