[jira] [Commented] (CURATOR-140) Support the initial data for the node in InterProcessReadWriteLock

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CURATOR-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194995#comment-14194995 ] 

ASF GitHub Bot commented on CURATOR-140:
----------------------------------------

Github user brienwheeler-sqrrl commented on the pull request:

    https://github.com/apache/curator/pull/48#issuecomment-61538081
  
    Hi, I just pushed a test for setting the node data for CURATOR-140.
    
         Cheers,
         Brien
    
    
    On Wed, Oct 29, 2014 at 6:48 PM, cammckenzie <no...@github.com>
    wrote:
    
    > Thanks for the patch, it looks good. Would you be able to provide a unit
    > test that covers the new functionality?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/curator/pull/48#issuecomment-61018683>.
    >


> Support the initial data for the node in InterProcessReadWriteLock
> ------------------------------------------------------------------
>
>                 Key: CURATOR-140
>                 URL: https://issues.apache.org/jira/browse/CURATOR-140
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Recipes
>            Reporter: Azrael
>            Priority: Minor
>
> Currently, locks(writeLock, readLock) in InterProcessReadWriteLock use the InetAddress for a initial data for the node, It is a little difficult to debug the lock owner as it shows only IP. If the initial data for lock node can be set, participantNodes contains the given information(hostname, id). So, it is easy  to debug participantNodes.
> {code}
> writeLock = InterProcessReadWriteLock.writeLock();
> Collection<String> nodes = writeLock.getParticipantNodes();
> for (String node: nodes) {
>     String nodeData = new String(client.getData().forPath(node));
> }
> {code} 
> {{nodeData}} should be the information which is given in argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)