You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/01 21:13:27 UTC

[Impala-CR](cdh5-trunk) IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables

Jim Apple has posted comments on this change.

Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables
......................................................................


Patch Set 3:

(1 comment)

Please update to using the new gerrit project, "Impala-ASF".
Instructions are here:

https://cwiki.apache.org/confluence/display/IMPALA/How+to+switch+to+Apache-hosted+git

Pushes to this project will be disabled on October 1.

http://gerrit.cloudera.org:8080/#/c/1966/3/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java:

PS3, Line 1162: it expects
> For the scenario that Jim describes, the user can uncache a table directly 
The order I suggest is not exactly a phenomenal experience, either, if the operation only completes part of its scheduled ops: if the uncaching happens but the table isn't dropped, presumably there could be a big performance hit when querying that table in the next session.


-- 
To view, visit http://gerrit.cloudera.org:8080/1966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <sz...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Marcell Szabo <sz...@cloudera.com>
Gerrit-HasComments: Yes