You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Gerlowski (JIRA)" <ji...@apache.org> on 2015/11/23 18:13:11 UTC
[jira] [Issue Comment Deleted] (SOLR-8324) Logger Untanglement
[ https://issues.apache.org/jira/browse/SOLR-8324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Gerlowski updated SOLR-8324:
----------------------------------
Comment: was deleted
(was: Hey Mike, just an FYI- I've got a patch almost finished that uses the MethodHandles approach. There was a little bit of back and forth about it on SOLR-8330 ("Remove shared loggers" subtask), but I guess I should've mentioned that I'd started on it here as well. My bad.
You're welcome to take it if you've also already started. Just wanted to let you know so we're not duplicating effort here.)
> Logger Untanglement
> -------------------
>
> Key: SOLR-8324
> URL: https://issues.apache.org/jira/browse/SOLR-8324
> Project: Solr
> Issue Type: Improvement
> Reporter: Mike Drob
> Fix For: Trunk
>
>
> I propose that we do a thorough examination of how we use loggers over the whole project. There are many instances of loggers being shared between classes that make troubleshooting difficult, and we can probably clean up some of the usage that has accumulated over numerous code moves and refactorings.
> Because this has the potential to scope wildly out of control, I would like to break the work down into several subtasks.
> * Loggers should be declared all three of {{private static final}} when possible. This both helps avoid the situations described in later bullets, and might provide a very minor performance improvement.
> * Distinct classes should not use loggers from other classes, unless they are explicitly delegated to do so.
> * Subclasses should declare their own loggers instead of relying on loggers from parent classes.
> * Examine if forbidden-api or some other tool(s) can help maintain this, once we reach a desired state.
> Each bullet might turn into one or more tasks, depending on how invasive individual changes become.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org