[GitHub] [iceberg] rdblue commented on a diff in pull request #5234: Core, API: BaseRowDelta to branch Impl

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r953200130


##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -133,19 +133,19 @@ protected void validate(TableMetadata base, Snapshot snapshot) {
     }
 
     if (validateNewDataFiles) {
-      validateAddedDataFiles(base, startingSnapshotId, dataConflictDetectionFilter());
+      validateAddedDataFiles(base, startingSnapshotId, dataConflictDetectionFilter(), snapshot);

Review Comment:
   Can we name this `parent` instead of `snapshot`? Snapshot is not very clear because there are a lot of snapshots.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org