You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2014/12/04 20:47:25 UTC
[jclouds-labs-google] To Mock Part II (#107)
Converts the following Apis to MockTests:
NetworkApi, OperationApi, RegionApi, RouteApi, and SnapshotApi
You can merge this Pull Request by running:
git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google toMockPartII
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/107
-- Commit Summary --
* began networkApiMockTest
* NetworkApi and OperationApi mockTests
* adding RegionApiMockTest
* Added RouteApiMockTest, SnapshotApiMockTest
-- File Changes --
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/NetworkApiExpectTest.java (153)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/NetworkApiMockTest.java (87)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/OperationApiExpectTest.java (274)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/OperationApiMockTest.java (166)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionApiExpectTest.java (89)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionApiMockTest.java (63)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RouteApiExpectTest.java (162)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RouteApiMockTest.java (98)
D google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/SnapshotApiExpectTest.java (89)
A google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/SnapshotApiMockTest.java (79)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseGlobalOperationListTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseNetworkListTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseNetworkTest.java (7)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionListTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRouteListTest.java (13)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRouteTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseSnapshotListTest.java (11)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseSnapshotTest.java (9)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/107.patch
https://github.com/jclouds/jclouds-labs-google/pull/107.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/107
Re: [jclouds-labs-google] To Mock Part II (#107)
Posted by Ignasi Barrera <no...@github.com>.
Fair enough. Thanks for explaining! Committed to master as [3e1d027](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;a=commit;h=3e1d027b5070280fe422c1c5f1f0b8127e133e2c).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/107#issuecomment-65721928
Re: [jclouds-labs-google] To Mock Part II (#107)
Posted by Ignasi Barrera <no...@github.com>.
Many thanks @danbroudy! This is very very much appreciated.
I've just done a quick overview and lgtm. Will do a detailed review tomorrow.
Just one question. Expect tests weren't annotated as `singleThreaded`. Is there any restriction that makes Mock tests have to run single threaded, or can we just remove that and let them concurrently?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/107#issuecomment-65718987
Re: [jclouds-labs-google] To Mock Part II (#107)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1834](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1834/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/107#issuecomment-65694091
Re: [jclouds-labs-google] To Mock Part II (#107)
Posted by Ignasi Barrera <no...@github.com>.
Closed #107.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/107#event-202987547
Re: [jclouds-labs-google] To Mock Part II (#107)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1833](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1833/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/107#issuecomment-65692473
Re: [jclouds-labs-google] To Mock Part II (#107)
Posted by danbroudy <no...@github.com>.
Unfortunately these Mock tests have to be single threaded because they are sharing the same server (aka queue) of responses. If they are multithreaded one test can enqueue the response it expects and another test can take that response causing a failure.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/107#issuecomment-65719632