You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2020/12/05 22:11:01 UTC
[jira] [Reopened] (HBASE-25361) [Flakey Tests] branch-2
TestMetaRegionLocationCache.testStandByMetaLocations
[ https://issues.apache.org/jira/browse/HBASE-25361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stack reopened HBASE-25361:
-----------------------------------
Reopen to apply addendum. Test just failed on me. Looking at my PR again, I'm missing reset of a counter so the new wait actually doesn't happen. Here is the addendum:
commit 7d0a687e5798a2f4ca3190b409169f7e17a75b34 (HEAD -> m, origin/master, origin/HEAD)
Author: stack <st...@apache.org>
Date: Sat Dec 5 14:00:18 2020 -0800
HBASE-25361 [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations (#2736)
Addendum; Reset counter so we actually wait in the new loop added by the
above.
{{diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaRegionLocationCache.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaRegionLocationCache.java}}
{{index 577e15cedf..2bcddc9ea7 100644}}
{{--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaRegionLocationCache.java}}
{{+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaRegionLocationCache.java}}
{{@@ -99,6 +99,7 @@ public class TestMetaRegionLocationCache {}}
{{ ZKWatcher zk = master.getZooKeeper();}}
{{ List<String> metaZnodes = zk.getMetaReplicaNodes();}}
{{ // Wait till all replicas available.}}
{{+ retries = 0;}}
{{ while (master.getMetaRegionLocationCache().getMetaRegionLocations().get().size() !=}}
{{ metaZnodes.size()) {}}
{{ Thread.sleep(1000);}}
> [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations
> ----------------------------------------------------------------------------
>
> Key: HBASE-25361
> URL: https://issues.apache.org/jira/browse/HBASE-25361
> Project: HBase
> Issue Type: Bug
> Components: flakies
> Reporter: Michael Stack
> Assignee: Michael Stack
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.4, 2.4.1
>
>
> This just happened to me running tests locally. I see it in the current flakies list [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2/310/testReport/junit/org.apache.hadoop.hbase.client/TestMetaRegionLocationCache/testStandByMetaLocations/]
>
> It looks like a simple timing issue. Let me put up a simple patch to see if it helps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)