[GitHub] [cassandra] josh-mckenzie commented on a diff in pull request #1778: Cassandra 17795 - Add support to generate a One-Shot heap dump on unhandled exceptions

[GitBox <gi...@apache.org>]

josh-mckenzie commented on code in PR #1778:
URL: https://github.com/apache/cassandra/pull/1778#discussion_r943641518


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1582,6 +1591,13 @@ public static void createAllDirectories()
                     throw new ConfigurationException("cdc_raw_directory must be specified", false);
                 FileUtils.createDirectory(conf.cdc_raw_directory);
             }
+
+            boolean created = maybeCreateHeapDumpPath();
+            if (!created && conf.dump_heap_on_uncaught_exception)
+            {
+                logger.error(String.format("conf.dump_heap_on_uncaught_exception is enabled but unable to create heap dump path %s. Disabling.", conf.heap_dump_path != null ? conf.heap_dump_path : "null"));

Review Comment:
   👍 agree; changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org