You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/12 06:45:11 UTC
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #50: Fix version compatibility for JSON-RPC4J Plugin
wu-sheng commented on a change in pull request #50:
URL: https://github.com/apache/skywalking-java/pull/50#discussion_r726807647
##########
File path: test/plugin/scenarios/jsonrpc4j-1.x-scenario/pom.xml
##########
@@ -57,7 +57,7 @@
<dependency>
<groupId>com.github.briandilley.jsonrpc4j</groupId>
<artifactId>jsonrpc4j</artifactId>
- <version>${jsonrpc.version}</version>
+ <version>${test.framework.version}</version>
Review comment:
This is correct fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org