You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2017/12/08 06:13:23 UTC

[GitHub] metamodel pull request #171: METAMODEL-1173: Fixed issue with evaluating Sca...

Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/171#discussion_r155709625
  
    --- Diff: core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
    @@ -406,18 +409,15 @@ protected DataSet materializeTable(final Table table, final List<SelectItem> sel
         }
     
         private List<SelectItem> buildWorkingSelectItems(List<SelectItem> selectItems, List<FilterItem> whereItems) {
    -        final List<SelectItem> primarySelectItems = new ArrayList<>(selectItems.size());
    -        for (SelectItem selectItem : selectItems) {
    --- End diff --
    
    Just to say it ... This is one of the things that I am really pleased to get rid of. Because the `MetaModelHelper.getFiltered` and `MetaModelHelper.getSelection` methods are now taking care of scalar functions, stuff like this for-loop is no longer needed.


---