You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "Aaron.Dossett" <Aa...@target.com> on 2015/06/30 23:21:46 UTC
A few recent pull requests for Hive Bolt
Hello,
I am beginning to use storm and also hope to contribute back to the project. Storm -> Hive is a primary use case for me, so I have been reading that source code quite a bit. I’ve made a few small pull requests based on what I’ve seen so far, I hope the community finds them helpful.
I’m looking forward to learning more and make more substantive contributions in the future!
Best, Aaron
Re: A few recent pull requests for Hive Bolt
Posted by "Aaron.Dossett" <Aa...@target.com>.
Thanks, Bobby! Here are my HiveBolt related PRs, I will let wiser people judge how much love they deserve :-)
PR #583 — make a HiveBolt test slightly more precise. This already has a +1
https://github.com/apache/storm/pull/583
PR #609 - resolve a minor dependency conflict in HiveBolt’s pom.xml. This cures a compilation warning and makes it possible for IntelliJ (and I assume other IDEs) to resolve all dependencies.
https://github.com/apache/storm/pull/609
PR #610 - HiveBolt code cleanups, no functionality changes
https://github.com/apache/storm/pull/610
I also have a non-HiveBolt PR that resolves most of STORM-799. This was a small change that I took on to get familiar with other portions of the code. The change is quite minor, but it did allow me to turn a potentially problematic run time type-check into a compile time check.
https://github.com/apache/storm/pull/607
Thanks everyone, any and all feedback on these PRs would be greatly appreciated!
Best, Aaron
On 7/6/15, 11:33 AM, "Bobby Evans" <ev...@yahoo-inc.com.INVALID>> wrote:
Aaron,
Great to hear it. We have been quite bad a reviewing and merging pull requests. If you do have one that does not seem to be getting the love it deserves please ping this list, or me directly if you prefer.
- Bobby
On Tuesday, June 30, 2015 4:22 PM, Aaron. Dossett <Aa...@target.com>> wrote:
Hello,
I am beginning to use storm and also hope to contribute back to the project. Storm -> Hive is a primary use case for me, so I have been reading that source code quite a bit. I’ve made a few small pull requests based on what I’ve seen so far, I hope the community finds them helpful.
I’m looking forward to learning more and make more substantive contributions in the future!
Best, Aaron
Re: A few recent pull requests for Hive Bolt
Posted by Bobby Evans <ev...@yahoo-inc.com.INVALID>.
Aaron,
Great to hear it. We have been quite bad a reviewing and merging pull requests. If you do have one that does not seem to be getting the love it deserves please ping this list, or me directly if you prefer.
- Bobby
On Tuesday, June 30, 2015 4:22 PM, Aaron. Dossett <Aa...@target.com> wrote:
Hello,
I am beginning to use storm and also hope to contribute back to the project. Storm -> Hive is a primary use case for me, so I have been reading that source code quite a bit. I’ve made a few small pull requests based on what I’ve seen so far, I hope the community finds them helpful.
I’m looking forward to learning more and make more substantive contributions in the future!
Best, Aaron