You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/06 16:03:36 UTC

[GitHub] [airflow] manesioz opened a new pull request #9698: feat: CloudVisionDeleteReferenceImageOperator 

manesioz opened a new pull request #9698:
URL: https://github.com/apache/airflow/pull/9698


   Fixes #9558 
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Target Github ISSUE in description if exists
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#discussion_r453103422



##########
File path: airflow/contrib/operators/gcp_vision_operator.py
##########
@@ -206,3 +207,19 @@ def __init__(self, *args, **kwargs):
             DeprecationWarning, stacklevel=3
         )
         super().__init__(*args, **kwargs)
+
+
+class CloudVisionReferenceImageDeleteOperator(CloudVisionDeleteReferenceImageOperator):

Review comment:
       We don't need it because this operator was not released in Airflow 1.10




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-658760076


   @manesioz What is your plan for the next contribution?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] manesioz commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
manesioz commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-657763623


   @mik-laj Done! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#discussion_r454923005



##########
File path: docs/howto/operator/google/cloud/vision.rst
##########
@@ -680,9 +680,71 @@ Templating
 More information
 """"""""""""""""
 
-See `Google Cloud Vision ReferenceImage create documentation
+See `Google Cloud Vision ReferenceImage delete documentation
 <https://googleapis.github.io/google-cloud-python/latest/vision/gapic/v1/api.html#google.cloud.vision_v1.ProductSearchClient.create_reference_image>`_.
 
+.. _howto/operator:CloudVisionDeleteReferenceImageOperator:
+
+CloudVisionDeleteReferenceImageOperator
+---------------------------------------
+
+Deletes a :code:`ReferenceImage` resource.
+
+For parameter definition, take a look at
+:class:`~airflow.providers.google.cloud.operators.vision.CloudVisionDeleteReferenceImageOperator`
+
+Using the operator
+""""""""""""""""""
+
+We are using the :class:`~google.cloud.vision_v1.types.ReferenceImage` and :class:`~google.api_core.retry.Retry` objects from Google libraries:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py

Review comment:
       ```suggestion
   .. exampleinclude:: /../airflow/providers/google/cloud/example_dags/example_vision.py
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-657778772


   @menesioz Can you update path in *include directives?
   ```
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:701: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:706: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:711: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:718: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:726: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:736: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/operators/vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:748: WARNING: Duplicate explicit target name: "howto/operator:cloudvisiondeletereferenceimageoperator".
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:763: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:768: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:773: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:780: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:788: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/example_dags/example_vision.py' not found or reading it failed
   /opt/airflow/docs/howto/operator/google/cloud/vision.rst:798: WARNING: Include file '/opt/airflow/docs/airflow/providers/google/cloud/operators/vision.py' not found or reading it failed
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] manesioz commented on pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
manesioz commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-654505904


   @mik-laj Yep! Good catch, done. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#discussion_r454923536



##########
File path: docs/howto/operator/google/cloud/vision.rst
##########
@@ -680,9 +680,71 @@ Templating
 More information
 """"""""""""""""
 
-See `Google Cloud Vision ReferenceImage create documentation
+See `Google Cloud Vision ReferenceImage delete documentation
 <https://googleapis.github.io/google-cloud-python/latest/vision/gapic/v1/api.html#google.cloud.vision_v1.ProductSearchClient.create_reference_image>`_.
 
+.. _howto/operator:CloudVisionDeleteReferenceImageOperator:
+
+CloudVisionDeleteReferenceImageOperator
+---------------------------------------
+
+Deletes a :code:`ReferenceImage` resource.
+
+For parameter definition, take a look at
+:class:`~airflow.providers.google.cloud.operators.vision.CloudVisionDeleteReferenceImageOperator`
+
+Using the operator
+""""""""""""""""""
+
+We are using the :class:`~google.cloud.vision_v1.types.ReferenceImage` and :class:`~google.api_core.retry.Retry` objects from Google libraries:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image_import]
+      :end-before: [END howto_operator_vision_reference_image_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_retry_import]
+      :end-before: [END howto_operator_vision_retry_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image]
+      :end-before: [END howto_operator_vision_reference_image]
+
+The ``product_set_id`` argument can be omitted (it will be generated by the API):
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :dedent: 4
+      :start-after: [START howto_operator_vision_reference_image_delete]
+      :end-before: [END howto_operator_vision_reference_image_delete]
+
+Or it can be specified explicitly:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py

Review comment:
       ```suggestion
   .. exampleinclude:: /../airflow/providers/google/cloud/example_dags/example_vision.py
   ```

##########
File path: docs/howto/operator/google/cloud/vision.rst
##########
@@ -680,9 +680,71 @@ Templating
 More information
 """"""""""""""""
 
-See `Google Cloud Vision ReferenceImage create documentation
+See `Google Cloud Vision ReferenceImage delete documentation
 <https://googleapis.github.io/google-cloud-python/latest/vision/gapic/v1/api.html#google.cloud.vision_v1.ProductSearchClient.create_reference_image>`_.
 
+.. _howto/operator:CloudVisionDeleteReferenceImageOperator:
+
+CloudVisionDeleteReferenceImageOperator
+---------------------------------------
+
+Deletes a :code:`ReferenceImage` resource.
+
+For parameter definition, take a look at
+:class:`~airflow.providers.google.cloud.operators.vision.CloudVisionDeleteReferenceImageOperator`
+
+Using the operator
+""""""""""""""""""
+
+We are using the :class:`~google.cloud.vision_v1.types.ReferenceImage` and :class:`~google.api_core.retry.Retry` objects from Google libraries:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image_import]
+      :end-before: [END howto_operator_vision_reference_image_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_retry_import]
+      :end-before: [END howto_operator_vision_retry_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image]
+      :end-before: [END howto_operator_vision_reference_image]
+
+The ``product_set_id`` argument can be omitted (it will be generated by the API):
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :dedent: 4
+      :start-after: [START howto_operator_vision_reference_image_delete]
+      :end-before: [END howto_operator_vision_reference_image_delete]
+
+Or it can be specified explicitly:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :dedent: 4
+      :start-after: [START howto_operator_vision_reference_image_delete_2]
+      :end-before: [END howto_operator_vision_reference_image_delete_2]
+
+
+Templating
+""""""""""
+
+.. literalinclude:: ../../../../airflow/providers/google/cloud/operators/vision.py

Review comment:
       ```suggestion
   .. literalinclude:: /../airflow/providers/google/cloud/operators/vision.py
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-657758808


   @manesioz Can you do a rebase?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-658759909


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] manesioz commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
manesioz commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-658753812


   Thank you @mik-laj ! Sorry for the typo. It's ready to merge whenever you are :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#discussion_r454923078



##########
File path: docs/howto/operator/google/cloud/vision.rst
##########
@@ -680,9 +680,71 @@ Templating
 More information
 """"""""""""""""
 
-See `Google Cloud Vision ReferenceImage create documentation
+See `Google Cloud Vision ReferenceImage delete documentation
 <https://googleapis.github.io/google-cloud-python/latest/vision/gapic/v1/api.html#google.cloud.vision_v1.ProductSearchClient.create_reference_image>`_.
 
+.. _howto/operator:CloudVisionDeleteReferenceImageOperator:
+
+CloudVisionDeleteReferenceImageOperator
+---------------------------------------
+
+Deletes a :code:`ReferenceImage` resource.
+
+For parameter definition, take a look at
+:class:`~airflow.providers.google.cloud.operators.vision.CloudVisionDeleteReferenceImageOperator`
+
+Using the operator
+""""""""""""""""""
+
+We are using the :class:`~google.cloud.vision_v1.types.ReferenceImage` and :class:`~google.api_core.retry.Retry` objects from Google libraries:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image_import]
+      :end-before: [END howto_operator_vision_reference_image_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py

Review comment:
       ```suggestion
   .. exampleinclude:: /../airflow/providers/google/cloud/example_dags/example_vision.py
   ```

##########
File path: docs/howto/operator/google/cloud/vision.rst
##########
@@ -680,9 +680,71 @@ Templating
 More information
 """"""""""""""""
 
-See `Google Cloud Vision ReferenceImage create documentation
+See `Google Cloud Vision ReferenceImage delete documentation
 <https://googleapis.github.io/google-cloud-python/latest/vision/gapic/v1/api.html#google.cloud.vision_v1.ProductSearchClient.create_reference_image>`_.
 
+.. _howto/operator:CloudVisionDeleteReferenceImageOperator:
+
+CloudVisionDeleteReferenceImageOperator
+---------------------------------------
+
+Deletes a :code:`ReferenceImage` resource.
+
+For parameter definition, take a look at
+:class:`~airflow.providers.google.cloud.operators.vision.CloudVisionDeleteReferenceImageOperator`
+
+Using the operator
+""""""""""""""""""
+
+We are using the :class:`~google.cloud.vision_v1.types.ReferenceImage` and :class:`~google.api_core.retry.Retry` objects from Google libraries:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image_import]
+      :end-before: [END howto_operator_vision_reference_image_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_retry_import]
+      :end-before: [END howto_operator_vision_retry_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py

Review comment:
       ```suggestion
   .. exampleinclude:: /../airflow/providers/google/cloud/example_dags/example_vision.py
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9698:
URL: https://github.com/apache/airflow/pull/9698


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] manesioz commented on a change in pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
manesioz commented on a change in pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#discussion_r453338104



##########
File path: airflow/contrib/operators/gcp_vision_operator.py
##########
@@ -206,3 +207,19 @@ def __init__(self, *args, **kwargs):
             DeprecationWarning, stacklevel=3
         )
         super().__init__(*args, **kwargs)
+
+
+class CloudVisionReferenceImageDeleteOperator(CloudVisionDeleteReferenceImageOperator):

Review comment:
       Removed, thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#discussion_r454923216



##########
File path: docs/howto/operator/google/cloud/vision.rst
##########
@@ -680,9 +680,71 @@ Templating
 More information
 """"""""""""""""
 
-See `Google Cloud Vision ReferenceImage create documentation
+See `Google Cloud Vision ReferenceImage delete documentation
 <https://googleapis.github.io/google-cloud-python/latest/vision/gapic/v1/api.html#google.cloud.vision_v1.ProductSearchClient.create_reference_image>`_.
 
+.. _howto/operator:CloudVisionDeleteReferenceImageOperator:
+
+CloudVisionDeleteReferenceImageOperator
+---------------------------------------
+
+Deletes a :code:`ReferenceImage` resource.
+
+For parameter definition, take a look at
+:class:`~airflow.providers.google.cloud.operators.vision.CloudVisionDeleteReferenceImageOperator`
+
+Using the operator
+""""""""""""""""""
+
+We are using the :class:`~google.cloud.vision_v1.types.ReferenceImage` and :class:`~google.api_core.retry.Retry` objects from Google libraries:
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image_import]
+      :end-before: [END howto_operator_vision_reference_image_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_retry_import]
+      :end-before: [END howto_operator_vision_retry_import]
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
+      :language: python
+      :start-after: [START howto_operator_vision_reference_image]
+      :end-before: [END howto_operator_vision_reference_image]
+
+The ``product_set_id`` argument can be omitted (it will be generated by the API):
+
+.. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py

Review comment:
       ```suggestion
   .. exampleinclude:: /../airflow/providers/google/cloud/example_dags/example_vision.py
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#discussion_r453930297



##########
File path: docs/howto/operator/google/cloud/vision.rst
##########
@@ -683,6 +683,68 @@ More information
 See `Google Cloud Vision ReferenceImage create documentation
 <https://googleapis.github.io/google-cloud-python/latest/vision/gapic/v1/api.html#google.cloud.vision_v1.ProductSearchClient.create_reference_image>`_.
 
+.. _howto/operator:CloudVisionDeleteReferenceImageOperator:
+
+CloudVisionDeleteReferenceImageOperator
+---------------------------------------
+
+Deletes a :code:`ReferenceImage` resource.
+
+For parameter definition, take a look at
+:class:`~airflow.providers.google.cloud.operators.vision.CloudVisionDeleteReferenceImageOperator`
+
+Using the operator
+""""""""""""""""""
+
+We are using the :class:`~google.cloud.vision_v1.types.ReferenceImage` and :class:`~google.api_core.retry.Retry` objects from Google libraries:
+
+.. exampleinclude:: airflow/airflow/providers/google/cloud/example_dags/example_vision.py

Review comment:
       ```suggestion
   .. exampleinclude:: /../airflow/airflow/providers/google/cloud/example_dags/example_vision.py
   ```
   See: https://github.com/apache/airflow/pull/9797




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-658677662


   I accepted my suggestions because it is an obvious typo and I would like to check it on CI. It does not affect the behavior or the final result.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] manesioz commented on pull request #9698: Add CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
manesioz commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-658761368


   I'll continue to look for manageable tickets -- I'd love to continue contributing as much as possible. If you have any ideas feel free to reach out :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-654326453


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://apache-airflow-slack.herokuapp.com/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #9698: feat: CloudVisionDeleteReferenceImageOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9698:
URL: https://github.com/apache/airflow/pull/9698#issuecomment-654487591


   Can you also update docs here?
   https://github.com/apache/airflow/blob/1d36b0303b8632fce6de78ca4e782ae26ee06fea/airflow/providers/google/cloud/hooks/vision.py#L428


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org