You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/02/22 22:35:21 UTC

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12559


Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................

IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Change-Id: Id134036026876238622cb182f790ac0f46654654
---
M docs/shared/impala_common.xml
M docs/topics/impala_bigint.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_timestamp.xml
4 files changed, 152 insertions(+), 109 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12559/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/235/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 20:10:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Zoltan Ivanfi, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12559

to look at the new patch set (#3).

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................

IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Change-Id: Id134036026876238622cb182f790ac0f46654654
---
M docs/shared/impala_common.xml
M docs/topics/impala_bigint.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_timestamp.xml
4 files changed, 756 insertions(+), 508 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12559/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12559

to look at the new patch set (#2).

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................

IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Change-Id: Id134036026876238622cb182f790ac0f46654654
---
M docs/shared/impala_common.xml
M docs/topics/impala_bigint.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_timestamp.xml
4 files changed, 144 insertions(+), 101 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12559/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................

IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Change-Id: Id134036026876238622cb182f790ac0f46654654
Reviewed-on: http://gerrit.cloudera.org:8080/12559
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Ivanfi <zi...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_bigint.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_timestamp.xml
4 files changed, 746 insertions(+), 501 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Zoltan Ivanfi: Looks good to me, but someone else must approve
  Csaba Ringhofer: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/237/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 04:04:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml
File docs/topics/impala_parquet.xml:

http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml@1270
PS3, Line 1270:           <stentry>BINAR annotated with the UTF8 OriginalType</stentry>
> A "Y" is missing from the end of "BINAR[Y]"
Done


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml@1314
PS3, Line 1314:           <stentry>INT64 annotated with the TIMESTAMP_MICROS</stentry>
> "OriginalType" missing from "INT64 annotated with the TIMESTAMP_MICROS [Ori
Done


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:

http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@221
PS3, Line 221: values with
             :           the <codeph>OriginalType</codeph> annotation
> Change
Done


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@224
PS3, Line 224:           with the <codeph>LogicalType</codeph> annotation specifies whether UTC to local
> Change
Done


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@262
PS3, Line 262:           default for a performance reason, to avoid unexpected incompatibility problems
> This sentence is hard to understand, I would break into two sentences like 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 03:48:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 4:

Thank you, Zoltan!
How do I get +2?


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 06:45:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/231/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Feb 2019 22:35:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Zoltan Ivanfi, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12559

to look at the new patch set (#4).

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................

IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Change-Id: Id134036026876238622cb182f790ac0f46654654
---
M docs/shared/impala_common.xml
M docs/topics/impala_bigint.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_timestamp.xml
4 files changed, 746 insertions(+), 501 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/12559/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/232/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Feb 2019 22:54:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Zoltan Ivanfi (Code Review)" <ge...@cloudera.org>.
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 4: Code-Review+1

LGTM, thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 06:31:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 2:

The changes look good to me, but I have some doubts about this information's relevance for users - understanding the difference between physical type / original type (=converted type) / logical type needs some knowledge about Parquet and its history. It would help a lot to have a table with Hadoop components / versions and the type of timestamp they write in Parquet, and the problems we can expect when reading these with Impala.

I have added Zoltan Ivanfi as reviewer.


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Feb 2019 11:10:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/232/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Feb 2019 22:49:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 3:

Zoltan and Csaba,
The Google Doc version of the changes are shared with you. Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 20:01:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/237/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 03:48:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Zoltan Ivanfi (Code Review)" <ge...@cloudera.org>.
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 4:

> Thank you, Zoltan!
 > How do I get +2?

Gerrit only allows me to give a +1, one of the other reviewers can give you a +2. (I'm not an Impala committer myself, I just coordinate cross-component timestamp efforts.)


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 06:50:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 13:17:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Zoltan Ivanfi (Code Review)" <ge...@cloudera.org>.
Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml
File docs/topics/impala_parquet.xml:

http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml@1270
PS3, Line 1270:           <stentry>BINAR annotated with the UTF8 OriginalType</stentry>
A "Y" is missing from the end of "BINAR[Y]"


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_parquet.xml@1314
PS3, Line 1314:           <stentry>INT64 annotated with the TIMESTAMP_MICROS</stentry>
"OriginalType" missing from "INT64 annotated with the TIMESTAMP_MICROS [OriginalType]"


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml
File docs/topics/impala_timestamp.xml:

http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@221
PS3, Line 221: values with
             :           the <codeph>OriginalType</codeph> annotation
Change
  values with the <codeph>OriginalType</codeph> annotation
to
  values annotated with the <codeph>TIMESTAMP_MILLIS</codeph> or <codeph>TIMESTAMP_MICROS</codeph> OriginalType


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@224
PS3, Line 224:           with the <codeph>LogicalType</codeph> annotation specifies whether UTC to local
Change
  with the <codeph>LogicalType</codeph> annotation
to
  annotated with the <codeph>TIMESTAMP</codeph> LogicalType


http://gerrit.cloudera.org:8080/#/c/12559/3/docs/topics/impala_timestamp.xml@262
PS3, Line 262:           default for a performance reason, to avoid unexpected incompatibility problems
This sentence is hard to understand, I would break into two sentences like this:

... is turned off by default for a performance reason. In order to avoid unexpected incompatibility problems, ...



-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 13:40:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 2:

> > The changes look good to me, but I have some doubts about this
 > > information's relevance for users - understanding the difference
 > > between physical type / original type (=converted type) / logical
 > > type needs some knowledge about Parquet and its history. It would
 > > help a lot to have a table with Hadoop components / versions and
 > > the type of timestamp they write in Parquet, and the problems we
 > > can expect when reading these with Impala.
 > >
 > > I have added Zoltan Ivanfi as reviewer.
 > 
 > I know! It took me a while to read up and understand the previous
 > notation for logical types. Let me know what else I can add to make
 > it easier to understand.
 > Meanwhile, your idea about a new table with timestamp is excellent.
 > 
 > > The changes look good to me, but I have some doubts about this
 > > information's relevance for users - understanding the difference
 > > between physical type / original type (=converted type) / logical
 > > type needs some knowledge about Parquet and its history. It would
 > > help a lot to have a table with Hadoop components / versions and
 > > the type of timestamp they write in Parquet, and the problems we
 > > can expect when reading these with Impala.
 > >
 > > I have added Zoltan Ivanfi as reviewer.
 > 
 > I totally agree. It took me a while to read up and understand the
 > original notation for the logical types. Let me know what else we
 > can add to make it easier to understand.
 > Your idea about a new table with various components and timestamps
 > is excellent. If you have that information readily available, I can
 > use it. Otherwise, I will create a separate ticket to for that task
 > after the release.

I agree with creating a separate ticket for creating the table. It will be more useful once the int64 write paths will be already released in Hive and Impala.


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 13:16:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 2:

> The changes look good to me, but I have some doubts about this
 > information's relevance for users - understanding the difference
 > between physical type / original type (=converted type) / logical
 > type needs some knowledge about Parquet and its history. It would
 > help a lot to have a table with Hadoop components / versions and
 > the type of timestamp they write in Parquet, and the problems we
 > can expect when reading these with Impala.
 > 
 > I have added Zoltan Ivanfi as reviewer.

I know! It took me a while to read up and understand the previous notation for logical types. Let me know what else I can add to make it easier to understand.
Meanwhile, your idea about a new table with timestamp is excellent. 

 > The changes look good to me, but I have some doubts about this
 > information's relevance for users - understanding the difference
 > between physical type / original type (=converted type) / logical
 > type needs some knowledge about Parquet and its history. It would
 > help a lot to have a table with Hadoop components / versions and
 > the type of timestamp they write in Parquet, and the problems we
 > can expect when reading these with Impala.
 > 
 > I have added Zoltan Ivanfi as reviewer.

I totally agree. It took me a while to read up and understand the original notation for the logical types. Let me know what else we can add to make it easier to understand.
Your idea about a new table with various components and timestamps is excellent. If you have that information readily available, I can use it. Otherwise, I will create a separate ticket to for that task after the release.


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Feb 2019 23:53:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/231/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Feb 2019 22:52:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12559 )

Change subject: IMPALA-7725: [DOCS] Support for Parquet INT64 Timestamp in Impala
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/235/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/12559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id134036026876238622cb182f790ac0f46654654
Gerrit-Change-Number: 12559
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoltan Ivanfi <zi...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 19:50:13 +0000
Gerrit-HasComments: No