You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by am...@apache.org on 2002/05/02 04:07:03 UTC
cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java
amyroh 02/05/01 19:07:03
Modified: coyote/src/java/org/apache/coyote/tomcat4
CoyoteServerSocketFactory.java
Log:
Add missing "public" for getFactory. Couldn't access the method through
reflection without being public.
Revision Changes Path
1.2 +1 -1 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteServerSocketFactory.java
Index: CoyoteServerSocketFactory.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteServerSocketFactory.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- CoyoteServerSocketFactory.java 9 Apr 2002 17:47:07 -0000 1.1
+++ CoyoteServerSocketFactory.java 2 May 2002 02:07:03 -0000 1.2
@@ -158,7 +158,7 @@
*/
private String keystorePass = "changeit";
- String getKeystorePass() {
+ public String getKeystorePass() {
return (this.keystorePass);
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <co...@covalent.net>
To: "Tomcat Developers List" <to...@jakarta.apache.org>
Sent: Wednesday, May 01, 2002 8:19 PM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4
CoyoteServerSocketFactory.java
> On Wed, 1 May 2002, Bill Barker wrote:
>
> > > Add missing "public" for getFactory. Couldn't access the method
through
> > > reflection without being public.
> > >
> > > Revision Changes Path
> > > 1.2 +1 -1
> >
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteSe
> > rverSocketFactory.java
> >
> > I had thought that we had agreed to deprecate this one (in favor of some
day
> > being able to get PureTLS working in 4.1.x). Not that I object to Amy's
> > change, but I hate to see her wasting her time on something that is
going
> > away.
>
> I thought PureTLS was working in 4.1.x ( and coyote ). At least the
> networking code has all the hooks, there are just few problems with the
> certs.
>
> Is there any additional problem ?
>
The problem is that o.a.c.tomcat4 doesn't play nice with others ;-).
PureTLS has additional attritubutes that aren't being passed through. This
can be fixed easily enough by (like TC3.3) adding a set/getAttribute &
set/getProperty methods. The other problem is that the o.a.c.Request
attributes aren't passed through to the ServletRequest (AFAIK, this should
cause problems for JK2 as well).
> ( if we're going to deprecate, it would be good to do it before the
> release )
>
It doesn't serve any useful purpose anymore (the actual SocketFactory is in
o.a.t.u.net), but I'd deprecate rather than remove (for now), since Coyote
is also used in 4.0.x.
> Costin
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4
CoyoteServerSocketFactory.java
Posted by co...@covalent.net.
On Wed, 1 May 2002, Bill Barker wrote:
> > Add missing "public" for getFactory. Couldn't access the method through
> > reflection without being public.
> >
> > Revision Changes Path
> > 1.2 +1 -1
> jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteSe
> rverSocketFactory.java
>
> I had thought that we had agreed to deprecate this one (in favor of some day
> being able to get PureTLS working in 4.1.x). Not that I object to Amy's
> change, but I hate to see her wasting her time on something that is going
> away.
I thought PureTLS was working in 4.1.x ( and coyote ). At least the
networking code has all the hooks, there are just few problems with the
certs.
Is there any additional problem ?
( if we're going to deprecate, it would be good to do it before the
release )
Costin
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java
Posted by Bill Barker <wb...@wilshire.com>.
----- Original Message -----
From: <am...@apache.org>
To: <ja...@apache.org>
Sent: Wednesday, May 01, 2002 7:07 PM
Subject: cvs commit:
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4
CoyoteServerSocketFactory.java
> amyroh 02/05/01 19:07:03
>
> Modified: coyote/src/java/org/apache/coyote/tomcat4
> CoyoteServerSocketFactory.java
> Log:
> Add missing "public" for getFactory. Couldn't access the method through
> reflection without being public.
>
> Revision Changes Path
> 1.2 +1 -1
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteSe
rverSocketFactory.java
I had thought that we had agreed to deprecate this one (in favor of some day
being able to get PureTLS working in 4.1.x). Not that I object to Amy's
change, but I hate to see her wasting her time on something that is going
away.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>