You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/23 11:40:13 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2061: Refactor arm interrupt stack related code

xiaoxiang781216 edited a comment on pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#issuecomment-715285984


   > @masayuki2009 - I have tested this. My only 2 concerns are 1) Not rounding UP (see [#2061 (comment)]
   
   The rounddown exist for a long time and nobody complain this behvaiour. if you think the roundup is better, please create a new PR to fix it.
   
   (https://github.com/apache/incubator-nuttx/pull/2061#discussion_r510786581)), and 2 this change:
   > 
   > ![image](https://user-images.githubusercontent.com/1945821/96992842-49010c00-14df-11eb-8c37-bb89b5aeb6b0.png)
   > 
   > Would you help me understand if is it correct?
   > 
   > Are we using Descending Empty or Descending Full?
   
   We can't select here, ARM require the descending full stack:
   https://static.docs.arm.com/ihi0042/f/IHI0042F_aapcs.pdf


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org