You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/02/24 01:34:36 UTC

[GitHub] [cxf] reta opened a new pull request #751: CXF-8429: Illegal reflective access in XercesSchemaValidationUtils

reta opened a new pull request #751:
URL: https://github.com/apache/cxf/pull/751


   Using `Xerces` as the substitution of the JDK's implementation (sealed even more in JDK16). Sadly, not all features are supported by `Xerces`, fe `http://javax.xml.XMLConstants/property/accessExternalSchema` is not recognizable. 
   
   @ffang could you please take a look? thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] reta commented on a change in pull request #751: CXF-8429: Illegal reflective access in XercesSchemaValidationUtils

Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #751:
URL: https://github.com/apache/cxf/pull/751#discussion_r581534734



##########
File path: rt/wsdl/pom.xml
##########
@@ -119,4 +117,19 @@
             </plugin>
         </plugins>
     </build>
+    
+    <profiles>
+        <profile>
+            <id>xerces</id>
+            <activation>
+                <jdk>[9,)</jdk>
+            </activation>
+            <dependencies>
+                <dependency>

Review comment:
       @ffang Another option I've been considering is opt-in model, remove profile and have `xercesImpl` as optional dependency:
   
   ```
                  <dependency>
                       <groupId>xerces</groupId>
                       <artifactId>xercesImpl</artifactId>
                       <optional>true</optional>
                   </dependency>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] ffang commented on pull request #751: CXF-8429: Illegal reflective access in XercesSchemaValidationUtils

Posted by GitBox <gi...@apache.org>.
ffang commented on pull request #751:
URL: https://github.com/apache/cxf/pull/751#issuecomment-785119120


   @reta yes, I think so


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] ffang commented on pull request #751: CXF-8429: Illegal reflective access in XercesSchemaValidationUtils

Posted by GitBox <gi...@apache.org>.
ffang commented on pull request #751:
URL: https://github.com/apache/cxf/pull/751#issuecomment-785101395


   @reta I think a jdk9+ profile should be good for now.
   
   Hopefully later xerces-impl release could have more advanced features support to keep up with the one from JDK for external usage, since the com.sun.org.apache.xerces.internal* package really means internal usage for later JDKs
   
   Thanks!
   Freeman


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] reta commented on pull request #751: CXF-8429: Illegal reflective access in XercesSchemaValidationUtils

Posted by GitBox <gi...@apache.org>.
reta commented on pull request #751:
URL: https://github.com/apache/cxf/pull/751#issuecomment-785118137


   Thanks @ffang , so we are good to merge?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cxf] reta merged pull request #751: CXF-8429: Illegal reflective access in XercesSchemaValidationUtils

Posted by GitBox <gi...@apache.org>.
reta merged pull request #751:
URL: https://github.com/apache/cxf/pull/751


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org