You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2012/11/16 05:38:17 UTC

[jira] [Created] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Lars Hofhansl created HBASE-7177:
------------------------------------

             Summary: TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
                 Key: HBASE-7177
                 URL: https://issues.apache.org/jira/browse/HBASE-7177
             Project: HBase
          Issue Type: Bug
            Reporter: Lars Hofhansl
            Assignee: Lars Hofhansl
             Fix For: 0.96.0, 0.94.4


Yes, this is my own test :(

Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498609#comment-13498609 ] 

Lars Hofhansl commented on HBASE-7177:
--------------------------------------

Hmm... I'd have to get handle on the actual RegionObserverCoprocessorEnvironment used. It's not entirely clear where to hook this up without leaking some ugly test code into the observer.
I'll add a TODO :)

                
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl resolved HBASE-7177.
----------------------------------

    Resolution: Fixed

Committed to 0.94 and 0.96 (also added TODO).
                
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-7177:
---------------------------------

    Attachment: 7177.txt

Trivial fix:
Just wait a bit for the change the propagate.
(Waiting a fixed time is never ideal, but in this case it will dramatically lower the probability that the changes have do not propagate in time)
                
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498682#comment-13498682 ] 

Hudson commented on HBASE-7177:
-------------------------------

Integrated in HBase-0.94 #596 (See [https://builds.apache.org/job/HBase-0.94/596/])
    HBASE-7177 TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky (Revision 1410200)

     Result = FAILURE
larsh : 
Files : 
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestZooKeeperScanPolicyObserver.java

                
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498752#comment-13498752 ] 

Hudson commented on HBASE-7177:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #264 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/264/])
    HBASE-7177 TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky (Revision 1410199)

     Result = SUCCESS
larsh : 
Files : 
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestZooKeeperScanPolicyObserver.java

                
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498608#comment-13498608 ] 

stack commented on HBASE-7177:
------------------------------

+1 on patch.  Could you just wait on the watcher triggering before proceeding?  Add that as a TODO when you commit?
                
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498605#comment-13498605 ] 

Lars Hofhansl edited comment on HBASE-7177 at 11/16/12 4:56 AM:
----------------------------------------------------------------

Trivial fix:
Just wait a bit for the change the propagate.
(Waiting a fixed time is never ideal, but in this case it will dramatically lower the probability that the changes do not propagate in time)
                
      was (Author: lhofhansl):
    Trivial fix:
Just wait a bit for the change the propagate.
(Waiting a fixed time is never ideal, but in this case it will dramatically lower the probability that the changes have do not propagate in time)
                  
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7177) TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498665#comment-13498665 ] 

Hudson commented on HBASE-7177:
-------------------------------

Integrated in HBase-TRUNK #3549 (See [https://builds.apache.org/job/HBase-TRUNK/3549/])
    HBASE-7177 TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky (Revision 1410199)

     Result = FAILURE
larsh : 
Files : 
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestZooKeeperScanPolicyObserver.java

                
> TestZooKeeperScanPolicyObserver.testScanPolicyObserver is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-7177
>                 URL: https://issues.apache.org/jira/browse/HBASE-7177
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7177.txt
>
>
> Yes, this is my own test :(
> Looking at the point where it fails frequently, it looks like the problem is just that the ZK does not hit the (asynchronous) ZKWatcher in the PolicyObserver in time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira