[jira] [Commented] (ACCUMULO-2812) Don't specify the arch in Makefile

["Christopher Tubbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999156#comment-13999156 ] 

Christopher Tubbs commented on ACCUMULO-2812:
---------------------------------------------

The assumption here is that most users will be building on the target system in which they want to run, and that their default compiler options support the current arch.

We could implement this with an additional environment variable to pass extra flags, and for convenience, those flags can be set from the build_native_library.sh command-line. I think that solution better supports different circumstances than simply forcing -m64 as is currently done.

> Don't specify the arch in Makefile
> ----------------------------------
>
>                 Key: ACCUMULO-2812
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2812
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: native
>    Affects Versions: 1.6.0
>            Reporter: Christopher Tubbs
>              Labels: newbie
>             Fix For: 1.6.1, 1.7.0
>
>         Attachments: ACCUMULO-2812.v1.patch
>
>
> Since we're no longer pre-building the native maps for distribution, and instead packaging a tiny C project to make it easier for users to create their own, it does not make sense for the Makefile to specify a specific architecture.
> Rather, it makes more sense that the Makefile that is packaged not specify the target architecture and instead rely on the current system architecture instead.
> I think all this would require is to drop -m64 from the CXXFLAGS, which seems fine for Linux. I'm not sure if this has any unintended side-effects for other systems, such as Mac.



--
This message was sent by Atlassian JIRA
(v6.2#6252)