You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "lichuang (via GitHub)" <gi...@apache.org> on 2026/01/24 14:32:18 UTC
[PR] refactor: unify SQL planning for ORDER BY, HAVING, DISTINCT, etc [datafusion]
lichuang opened a new pull request, #19974:
URL: https://github.com/apache/datafusion/pull/19974
## Which issue does this PR close?
refactor: unify SQL planning for ORDER BY, HAV ING, DISTINCT, etc
- Closes #10326
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: unify SQL planning for ORDER BY, HAVING, DISTINCT, etc [datafusion]
Posted by "lichuang (via GitHub)" <gi...@apache.org>.
lichuang commented on PR #19974:
URL: https://github.com/apache/datafusion/pull/19974#issuecomment-3824286848
@alamb thanks comment. After comment, I Simplified `order_by_to_sort_expr` by removeing the `additional_schema` parameter, which introduce in pr https://github.com/apache/datafusion/pull/10234, now that the code paths is unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: unify SQL planning for ORDER BY, HAVING, DISTINCT, etc [datafusion]
Posted by "lichuang (via GitHub)" <gi...@apache.org>.
lichuang closed pull request #19974: refactor: unify SQL planning for ORDER BY, HAVING, DISTINCT, etc
URL: https://github.com/apache/datafusion/pull/19974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: unify SQL planning for ORDER BY, HAVING, DISTINCT, etc [datafusion]
Posted by "lichuang (via GitHub)" <gi...@apache.org>.
lichuang commented on PR #19974:
URL: https://github.com/apache/datafusion/pull/19974#issuecomment-3809507231
@alamb @jonahgao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: unify SQL planning for ORDER BY, HAVING, DISTINCT, etc [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #19974:
URL: https://github.com/apache/datafusion/pull/19974#issuecomment-3813936398
In other words, this PR seems to add *more* code paths, when the idea was to reduce the code / duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] refactor: unify SQL planning for ORDER BY, HAVING, DISTINCT, etc [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #19974:
URL: https://github.com/apache/datafusion/pull/19974#issuecomment-3813934292
This seems to add more code (rather than unify the code paths as the PR comment suggests) 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org