You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/23 07:58:53 UTC

[GitHub] [airflow] hterik commented on a diff in pull request #26582: Reduce log verbosity in KubernetesExecutor.

hterik commented on code in PR #26582:
URL: https://github.com/apache/airflow/pull/26582#discussion_r978361476


##########
airflow/executors/kubernetes_executor.py:
##########
@@ -302,7 +302,6 @@ def run_next(self, next_job: KubernetesJobType) -> None:
         status
         """
         key, command, kube_executor_config, pod_template_file = next_job
-        self.log.info('Kubernetes job is %s', key)

Review Comment:
   This log is not really removed, you can say i moved it to line 335 to include the pod-name details in it. So unless anything fails on line 306-335 i believe it is ok. This path doesn't involve any external communication so all information relevant to an error would be hopefully be included in exceptions if any.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org