[GitHub] [flink] rmetzger commented on a change in pull request #14565: [FLINK-20596] Remove Scheduler

[GitBox <gi...@apache.org>]

rmetzger commented on a change in pull request #14565:
URL: https://github.com/apache/flink/pull/14565#discussion_r552431518



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/SlotRequestId.java
##########
@@ -18,14 +18,15 @@
 
 package org.apache.flink.runtime.jobmaster;
 
+import org.apache.flink.runtime.jobmaster.slotpool.PhysicalSlot;
+import org.apache.flink.runtime.jobmaster.slotpool.PhysicalSlotProvider;
 import org.apache.flink.runtime.jobmaster.slotpool.SlotPool;
-import org.apache.flink.runtime.jobmaster.slotpool.SlotProvider;
 import org.apache.flink.util.AbstractID;
 
 /**
- * This ID identifies the request for a logical slot from the Execution to the {@link SlotPool} oe
- * {@link SlotProvider}. The logical slot may be a physical slot or a sub-slot thereof, in the case
- * of slot sharing.
+ * This ID identifies the request for a slot from the Execution to the {@link SlotPool} oe {@link

Review comment:
       ```suggestion
    * This ID identifies the request for a slot from the Execution to the {@link SlotPool} or {@link
   ```

##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/PhysicalSlotProviderResource.java
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.jobmaster.slotpool;
+
+import org.apache.flink.runtime.clusterframework.types.ResourceProfile;
+import org.apache.flink.runtime.clusterframework.types.SlotProfile;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor;
+import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutorServiceAdapter;
+import org.apache.flink.runtime.jobmaster.SlotRequestId;
+
+import org.junit.rules.ExternalResource;
+
+import javax.annotation.Nonnull;
+
+import java.util.Arrays;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.function.Function;
+
+/**
+ * {@code PhysicalSlotProviderResource} is used for testing different {@code
+ * SlotSelectionStrategies} on {@link PhysicalSlotProviderImpl}.

Review comment:
       `SlotSelectionStrategies` doesn't exist?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org