You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by osma <gi...@git.apache.org> on 2016/05/02 10:27:47 UTC
[GitHub] jena pull request: JENA-1172: restore support for blank nodes in j...
GitHub user osma opened a pull request:
https://github.com/apache/jena/pull/137
JENA-1172: restore support for blank nodes in jena-text
It seems that jena-text used to support blank nodes in the text index (there is some infrastructure to support this, particularly in TextQueryFuncs) but this was broken by JENA-999 (internal caching) or possibly even earlier. There were no unit tests involving blank nodes that would have caught this.
This PR restores support for blank node subjects. There are a couple of very basic unit tests that check the basic functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/osma/jena jena-1172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit b793fcc9c3ff8ab44d418f5afe456d3dafd4d1e7
Author: Osma Suominen <os...@apache.org>
Date: 2016-05-02T07:41:56Z
JENA-1172: failing unit test (assumes blank node support will be implemented)
commit 01ec64590867be3ce377bdf509c2f88a2f1e70c3
Author: Osma Suominen <os...@apache.org>
Date: 2016-05-02T08:24:30Z
JENA-1172: restore support for blank nodes in jena-text
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1172: restore support for blank nodes in j...
Posted by osma <gi...@git.apache.org>.
Github user osma commented on the pull request:
https://github.com/apache/jena/pull/137#issuecomment-216165347
I made this into a PR rather than merging directly because I thought I may have missed something obvious. But if it looks good to others, I will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1172: restore support for blank nodes in j...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: JENA-1172: restore support for blank nodes in j...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/137#issuecomment-216488533
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---