You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2025/04/22 10:30:39 UTC

[PR] [MINOR] Clean up config inconsistency in recordKeyFields config [hudi]

voonhous opened a new pull request, #13205:
URL: https://github.com/apache/hudi/pull/13205

   ### Change Logs
   
   In `TestRecordLevelIndexWithSQL#testRLIWithThreeRecordKeyFields`, the config values for **primaryKey** and **hoodie.datasource.write.recordkey.field** are different.
   
   Although there are no test failures as the value in **hoodie.datasource.write.recordkey.field** will be used (superseding **primaryKey**), it is still good to clean this up.
   
   On top of that, the repeated config values are moved to a variable to reduce repeated declaration.
   
   ### Impact
   
   None
   
   ### Risk level (write none, low medium or high below)
   
   None
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [x] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Clean up config inconsistency in recordKeyFields config [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #13205:
URL: https://github.com/apache/hudi/pull/13205


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Clean up config inconsistency in recordKeyFields config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13205:
URL: https://github.com/apache/hudi/pull/13205#issuecomment-2820894181

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "78d97ea4f4df683ee78b7240dcd9c2472db4e9f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5065",
       "triggerID" : "78d97ea4f4df683ee78b7240dcd9c2472db4e9f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78d97ea4f4df683ee78b7240dcd9c2472db4e9f4 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5065) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Clean up config inconsistency in recordKeyFields config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13205:
URL: https://github.com/apache/hudi/pull/13205#issuecomment-2821328376

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "78d97ea4f4df683ee78b7240dcd9c2472db4e9f4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5065",
       "triggerID" : "78d97ea4f4df683ee78b7240dcd9c2472db4e9f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78d97ea4f4df683ee78b7240dcd9c2472db4e9f4 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=5065) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] Clean up config inconsistency in recordKeyFields config [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #13205:
URL: https://github.com/apache/hudi/pull/13205#issuecomment-2820890768

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "78d97ea4f4df683ee78b7240dcd9c2472db4e9f4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "78d97ea4f4df683ee78b7240dcd9c2472db4e9f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 78d97ea4f4df683ee78b7240dcd9c2472db4e9f4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org