You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/20 04:39:48 UTC
[GitHub] [incubator-druid] lml2468 commented on a change in pull request
#7682: Add checkstyle for "Prohibit @author tags in Javadoc"
lml2468 commented on a change in pull request #7682: Add checkstyle for "Prohibit @author tags in Javadoc"
URL: https://github.com/apache/incubator-druid/pull/7682#discussion_r285427084
##########
File path: CONTRIBUTING.md
##########
@@ -33,7 +33,6 @@ When submitting a pull request (PR), please use the following guidelines:
using "Feature/Change" template. Non-trivial features should include unit tests covering the new functionality. Open
a "Proposal" issue for large changes.
- Bugfixes should include a unit test or integration test reproducing the issue.
-- Do not use author tags/information in the code.
Review comment:
@himanshug @clintropolis Thanks. Addressed your comments, it has rolled back to its previous state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org