You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2026/01/22 08:47:00 UTC
[PR] [Bug](scan) fix coredump in attach_profile_counter defer [doris]
BiteTheDDDDt opened a new pull request, #60147:
URL: https://github.com/apache/doris/pull/60147
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](scan) fix coredump in attach_profile_counter defer [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60147:
URL: https://github.com/apache/doris/pull/60147#discussion_r2715902326
##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -364,7 +364,15 @@ Status ScanLocalState<Derived>::_normalize_predicate(vectorized::VExprContext* c
auto expr = root->is_rf_wrapper() ? root->get_impl() : root;
{
Defer attach_defer = [&]() {
- if (pdt != PushDownType::UNACCEPTABLE && root->is_rf_wrapper()) {
+ // eos is true means triggered short-circuit in predicate pushdown, predicates may empty
Review Comment:
Grammar issue in comment: "predicates may empty" should be "predicates may be empty".
```suggestion
// eos is true means triggered short-circuit in predicate pushdown, predicates may be empty
```
##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -364,7 +364,15 @@ Status ScanLocalState<Derived>::_normalize_predicate(vectorized::VExprContext* c
auto expr = root->is_rf_wrapper() ? root->get_impl() : root;
{
Defer attach_defer = [&]() {
- if (pdt != PushDownType::UNACCEPTABLE && root->is_rf_wrapper()) {
+ // eos is true means triggered short-circuit in predicate pushdown, predicates may empty
+ if (pdt != PushDownType::UNACCEPTABLE && root->is_rf_wrapper() &&
+ !_eos) {
+ if (_slot_id_to_predicates[slot->id()].empty()) {
+ return Status::InternalError(
+ "No predicate generated for runtime filter "
+ "from expr: {}",
+ root->debug_string());
Review Comment:
Returning a Status object from a Defer lambda is incorrect. The Defer destructor invokes the closure without expecting or handling a return value. The returned Status::InternalError will be silently discarded. If you need error handling here, consider logging the error or setting a status variable captured by the lambda that can be checked after the defer block executes.
```suggestion
status = Status::InternalError(
"No predicate generated for runtime filter "
"from expr: {}",
root->debug_string());
return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](scan) fix coredump in attach_profile_counter defer [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60147:
URL: https://github.com/apache/doris/pull/60147#issuecomment-3784282357
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (8/8)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/60147_e85fba5eda69042411f5b863013b997688cbd3b1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/60147_e85fba5eda69042411f5b863013b997688cbd3b1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.08% (26102/35719) |
| Line Coverage | 56.13% (277921/495108) |
| Region Coverage | 53.89% (231437/429481) |
| Branch Coverage | 55.61% (99854/179568) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](scan) fix coredump in attach_profile_counter defer [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #60147:
URL: https://github.com/apache/doris/pull/60147#issuecomment-3783608837
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](scan) fix coredump in attach_profile_counter defer [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #60147:
URL: https://github.com/apache/doris/pull/60147#issuecomment-3787892200
Fixed by #60162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](scan) fix coredump in attach_profile_counter defer [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60147:
URL: https://github.com/apache/doris/pull/60147#issuecomment-3783231958
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Bug](scan) fix coredump in attach_profile_counter defer [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 closed pull request #60147: [Bug](scan) fix coredump in attach_profile_counter defer
URL: https://github.com/apache/doris/pull/60147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org