You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Daniel Dai <da...@gmail.com> on 2011/05/13 18:58:08 UTC
Review Request: FilterLogicExpressionSimplifier removed some branches in
some cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/743/
-----------------------------------------------------------
Review request for pig and Richard Ding.
Summary
-------
See PIG-2067
This addresses bug PIG-2067.
https://issues.apache.org/jira/browse/PIG-2067
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/ProjectExpression.java 1102169
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/UserFuncExpression.java 1102169
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/rules/LogicalExpressionSimplifier.java 1102169
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestFilterSimplification.java 1102169
Diff: https://reviews.apache.org/r/743/diff
Testing
-------
Unit test:
all pass
End-to-end test:
all pass
Thanks,
Daniel
Re: Review Request: FilterLogicExpressionSimplifier removed some branches in
some cases
Posted by Daniel Dai <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/743/
-----------------------------------------------------------
(Updated 2011-05-13 18:13:38.714903)
Review request for pig and Richard Ding.
Summary
-------
See PIG-2067
This addresses bug PIG-2067.
https://issues.apache.org/jira/browse/PIG-2067
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/ProjectExpression.java 1102169
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/UserFuncExpression.java 1102169
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/rules/LogicalExpressionSimplifier.java 1102169
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestFilterSimplification.java 1102169
Diff: https://reviews.apache.org/r/743/diff
Testing (updated)
-------
Test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 562 release audit warnings (more than the trunk's current 561 warnings).
Ignore release audit warning since no new file is added.
Unit test:
all pass
End-to-end test:
all pass
Thanks,
Daniel