You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwhisk.apache.org by Michele Sciabarra <op...@sciabarra.com> on 2018/03/16 07:56:25 UTC

Working on Swift actions and Go source support

Hi, a quick note about what I am working on (is not the mailing supposed to be used for communicating this sort of things with the community?).

I agreed with Carlos I will try to patch the swift images to use my Go based proxy.

In the process, I will have to add source support to my golang proxy (currently it is binary only), so there will be a "gobuild.sh" in the go image as there is now a "swiftbuild.sh" in the Swift Images.

If someone is also working on that area please let me know to avoid overlap.

-- 
  Michele Sciabarra
  openwhisk@sciabarra.com

Re: Working on Swift actions and Go source support

Posted by Michele Sciabarra <mi...@sciabarra.com>.
On Sat, Mar 24, 2018, at 4:57 PM, Rodric Rabbah wrote:
> I'm not sure btw why you used the IBM Ubuntu image in the Dockerfile - any
> particular reason?
> 
> -r
Because  Carlos asked me to use the goproxy for implementing a faster version of the swift actions.
Since the swift actions are based on that image, I used the same base image, so you can replace the
FROM ibmcom/ubuntu:14.04 
with
FROM openwhisk/goproxy:1.0.0

and then reuse the code already available in the Swift images.

The idea is to add something like /build /action/exec that is invoked to build go or swift or... whatever :)

Re: Working on Swift actions and Go source support

Posted by Rodric Rabbah <ro...@gmail.com>.
I'm not sure btw why you used the IBM Ubuntu image in the Dockerfile - any
particular reason?

-r

Re: Working on Swift actions and Go source support

Posted by Rodric Rabbah <ro...@gmail.com>.
Hi Michele, thanks for the PRs.

May I suggest breaking this large PR against this repo
https://github.com/apache/incubator-openwhisk-runtime-go into several
smaller and incremental ones?

   1. an initial commit, adding contributing doc, license, gradle structure
   and ancillary files
   2. the go proxy
   3. the go action support
   4. the swift support

This is so we can get commits in more quickly and focus the review on the
critical parts vs the 2500+ lines of added code much of which is boiler
plate we can skip.

I made an initial pass moments ago just to understand the overall
structure. Also Thanks to Vadim who's looked through the go logic already.
If you break the PR up, we can isolate the reviewers to the relevant people
and move a bit more quickly on integration.

-r


On Fri, Mar 16, 2018 at 4:22 AM, Michele Sciabarra <mi...@sciabarra.com>
wrote:

> Well,  here is a more detailed status update:
>
> Released an implementation of Go Actions: submitted a huge PR here:
>
>    https://github.com/apache/incubator-openwhisk-runtime-go
>
> basically handing over the content of
>
>    https://github.com/sciabarracom/incubator-openwhisk-runtime-go
>
> Now working on the swift actions:
>
> https://github.com/apache/incubator-openwhisk-runtime-swift
>
> to use my Go based proxy.
>
> In the process I need to implement source support, for both whisk and go
> (so far Go runtime is binary only).
>
>
> --
>   Michele Sciabarra
>   michele@sciabarra.com
>
> On Fri, Mar 16, 2018, at 8:58 AM, Bertrand Delacretaz wrote:
> > Hi,
> >
> > On Fri, Mar 16, 2018 at 8:56 AM, Michele Sciabarra
> > <op...@sciabarra.com> wrote:
> > > ..is not the mailing supposed to be used for communicating this sort
> of things with the community?...
> >
> > That's the role of this list indeed!
> >
> > As OpenWhisk has many Git repositories I think it's great to include
> > the URLs of what you're talking about - it helps people like me who
> > are trying to generally keep up with what's happening, without being
> > closely involved in anything in particular (so far ;-)
> >
> > -Bertrand
>

Re: Working on Swift actions and Go source support

Posted by Michele Sciabarra <mi...@sciabarra.com>.
Well,  here is a more detailed status update:

Released an implementation of Go Actions: submitted a huge PR here:

   https://github.com/apache/incubator-openwhisk-runtime-go

basically handing over the content of

   https://github.com/sciabarracom/incubator-openwhisk-runtime-go

Now working on the swift actions:

https://github.com/apache/incubator-openwhisk-runtime-swift

to use my Go based proxy.

In the process I need to implement source support, for both whisk and go (so far Go runtime is binary only).


-- 
  Michele Sciabarra
  michele@sciabarra.com

On Fri, Mar 16, 2018, at 8:58 AM, Bertrand Delacretaz wrote:
> Hi,
> 
> On Fri, Mar 16, 2018 at 8:56 AM, Michele Sciabarra
> <op...@sciabarra.com> wrote:
> > ..is not the mailing supposed to be used for communicating this sort of things with the community?...
> 
> That's the role of this list indeed!
> 
> As OpenWhisk has many Git repositories I think it's great to include
> the URLs of what you're talking about - it helps people like me who
> are trying to generally keep up with what's happening, without being
> closely involved in anything in particular (so far ;-)
> 
> -Bertrand

Re: Working on Swift actions and Go source support

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,

On Fri, Mar 16, 2018 at 8:56 AM, Michele Sciabarra
<op...@sciabarra.com> wrote:
> ..is not the mailing supposed to be used for communicating this sort of things with the community?...

That's the role of this list indeed!

As OpenWhisk has many Git repositories I think it's great to include
the URLs of what you're talking about - it helps people like me who
are trying to generally keep up with what's happening, without being
closely involved in anything in particular (so far ;-)

-Bertrand