You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2023/05/30 11:17:05 UTC

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3207: FINERACT-1926: Asset transfer to external owner COB business step

adamsaghy commented on code in PR #3207:
URL: https://github.com/apache/fineract/pull/3207#discussion_r1210121147


##########
fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java:
##########
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.investor.cob.loan;
+
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.util.List;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.cob.loan.LoanCOBBusinessStep;
+import org.apache.fineract.infrastructure.core.service.DateUtils;
+import org.apache.fineract.investor.data.ExternalTransferStatus;
+import org.apache.fineract.investor.data.ExternalTransferSubStatus;
+import org.apache.fineract.investor.domain.ExternalAssetOwnerTransfer;
+import org.apache.fineract.investor.service.ExternalAssetOwnersReadService;
+import org.apache.fineract.investor.service.ExternalAssetOwnersWriteService;
+import org.apache.fineract.portfolio.loanaccount.domain.Loan;
+import org.springframework.stereotype.Component;
+
+@Component
+@RequiredArgsConstructor
+@Slf4j
+public class LoanAccountOwnerTransferBusinessStep implements LoanCOBBusinessStep {
+
+    private final ExternalAssetOwnersReadService externalAssetOwnersReadService;
+    private final ExternalAssetOwnersWriteService externalAssetOwnersWriteService;
+
+    @Override
+    public Loan execute(Loan loan) {
+        Long loanId = loan.getId();
+        log.debug("start processing loan ownership transfer business step for loan with Id [{}]", loanId);
+
+        LocalDate settlementDate = DateUtils.getBusinessLocalDate();
+        List<ExternalAssetOwnerTransfer> transferDataList = externalAssetOwnersReadService.retrieveTransfers(loanId, settlementDate,
+                List.of(ExternalTransferStatus.PENDING, ExternalTransferStatus.ACTIVE, ExternalTransferStatus.BUYBACK));
+        int size = transferDataList.size();
+
+        if (size > 2) {
+            throw new IllegalStateException(
+                    String.format("Found too many owner transfers(%s) by the settlement date(%s)", size, settlementDate));
+        } else if (size == 2) {
+            ExternalTransferStatus firstTransferStatus = transferDataList.get(0).getStatus();
+            ExternalTransferStatus secondTransferStatus = transferDataList.get(0).getStatus();
+
+            if (!ExternalTransferStatus.BUYBACK.equals(secondTransferStatus)) {
+                throw new IllegalStateException(String.format("Illegal transfer found. Expected %s, found: %s",
+                        ExternalTransferStatus.BUYBACK, secondTransferStatus));
+            }
+
+            switch (firstTransferStatus) {
+                case PENDING -> handleSameDaySaleAndBuyback(settlementDate, transferDataList);
+                case ACTIVE -> handleBuyback(loan, settlementDate, transferDataList);
+                default -> throw new IllegalStateException(String.format("Illegal transfer found. Expected %s or %s, found: %s",
+                        ExternalTransferStatus.PENDING, ExternalTransferStatus.ACTIVE, firstTransferStatus));
+            }
+        } else if (size == 1) {
+            handleSale(loan, settlementDate, transferDataList.get(0));
+        }
+
+        log.debug("end processing loan ownership transfer business step for loan Id [{}]", loan.getId());
+        return loan;
+    }
+
+    private void handleSale(final Loan loan, final LocalDate settlementDate, final ExternalAssetOwnerTransfer externalAssetOwnerTransfer) {
+        ExternalAssetOwnerTransfer newExternalAssetOwnerTransfer = sellAsset(loan, settlementDate, externalAssetOwnerTransfer);
+        // TODO: trigger asset loan transfer executed event
+    }
+
+    private void handleBuyback(final Loan loan, final LocalDate settlementDate,
+            final List<ExternalAssetOwnerTransfer> externalAssetOwnerTransferList) {
+        ExternalAssetOwnerTransfer newExternalAssetOwnerTransfer = buybackAsset(loan, settlementDate, externalAssetOwnerTransferList);
+        // TODO: trigger asset loan transfer executed event
+    }
+
+    private ExternalAssetOwnerTransfer buybackAsset(final Loan loan, final LocalDate settlementDate,
+            List<ExternalAssetOwnerTransfer> externalAssetOwnerTransferList) {
+        ExternalAssetOwnerTransfer saleExternalAssetOwnerTransfer = externalAssetOwnerTransferList.get(0);
+        ExternalAssetOwnerTransfer buybackExternalAssetOwnerTransfer = externalAssetOwnerTransferList.get(1);
+        saleExternalAssetOwnerTransfer.setEffectiveDateTo(settlementDate);
+        externalAssetOwnersWriteService.save(saleExternalAssetOwnerTransfer);
+        externalAssetOwnersWriteService.removeActiveMapping(loan.getId(), buybackExternalAssetOwnerTransfer);
+        // TODO: create asset ownership accounting entries
+        // TODO: create asset ownership transaction entries
+        return buybackExternalAssetOwnerTransfer;
+    }
+
+    private ExternalAssetOwnerTransfer sellAsset(final Loan loan, final LocalDate settlementDate,
+            final ExternalAssetOwnerTransfer externalAssetOwnerTransfer) {
+        ExternalAssetOwnerTransfer newExternalAssetOwnerTransfer;
+        if (isTransferable(loan)) {
+            newExternalAssetOwnerTransfer = createActiveEntry(settlementDate, externalAssetOwnerTransfer);
+            externalAssetOwnersWriteService.createActiveMapping(loan.getId(), newExternalAssetOwnerTransfer);
+            // TODO: create asset ownership accounting entries
+            // TODO: create asset ownership transaction entries
+        } else {
+            ExternalTransferSubStatus subStatus = ExternalTransferSubStatus.BALANCE_ZERO;
+            if (loan.getTotalOverpaid().compareTo(BigDecimal.ZERO) > 0) {
+                subStatus = ExternalTransferSubStatus.BALANCE_NEGATIVE;
+            }
+            newExternalAssetOwnerTransfer = createNewEntry(settlementDate, externalAssetOwnerTransfer, ExternalTransferStatus.DECLINED,
+                    subStatus, settlementDate, settlementDate);
+        }
+        return newExternalAssetOwnerTransfer;
+    }
+
+    private boolean isTransferable(final Loan loan) {
+        return loan.getLoanSummary().getTotalOutstanding().compareTo(BigDecimal.ZERO) > 0;

Review Comment:
   it means that, yeah...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org